docs: Refined ts code and cleaned up JS Doc

Ticket: TW-138

Author: vmccarty

src/advancedWalletManager/routers/healthCheck.ts

@@ -16,37 +16,43 @@ const VersionResponse: HttpResponse = {
 };
 
 /**
- * Ping Check
+ * Ping (AWM)
+ *
+ * Test your connection to the Advanced Wallet Manager (AWM) server.
+ *
+ * @tag Advanced Wallets
+ * @operationId advancedwallet.awm.ping
+ */
+const PingRoute = httpRoute({
+  method: 'POST',
+  path: '/ping',
+  request: httpRequest({}),
+  response: PingResponse,
+  description: 'Health check endpoint that returns server status',
+});
+
+/**
+ * Check Version (AWM)
+ *
+ * Check your version of the Advanced Wallet Manager (AWM) server.
  *
  * @tag Advanced Wallets
- * @operationId v1.health.ping
- * @private
+ * @operationId advancedwallet.awm.version
  */
+const VersionRoute = httpRoute({
+  method: 'GET',
+  path: '/version',
+  request: httpRequest({}),
+  response: VersionResponse,
+  description: 'Returns the current version of the server',
+});
+
 export const HealthCheckApiSpec = apiSpec({
-  'v1.health.ping': {
-    post: httpRoute({
-      method: 'POST',
-      path: '/ping',
-      request: httpRequest({}),
-      response: PingResponse,
-      description: 'Health check endpoint that returns server status',
-    }),
+  'advancedwallet.awm.ping': {
+    post: PingRoute,
   },
-  /**
-   * Version Check
-   *
-   * @tag Advanced Wallets
-   * @operationId v1.health.version
-   * @private
-   */
-  'v1.health.version': {
-    get: httpRoute({
-      method: 'GET',
-      path: '/version',
-      request: httpRequest({}),
-      response: VersionResponse,
-      description: 'Returns the current version of the server',
-    }),
+  'advancedwallet.awm.version': {
+    get: VersionRoute,
   },
 });
 
@@ -56,7 +62,7 @@ export function createHealthCheckRouter(): WrappedRouter<typeof HealthCheckApiSp
     decodeErrorFormatter: customDecodeErrorFormatter,
   });
   // Ping endpoint handler
-  router.post('v1.health.ping', [
+  router.post('advancedwallet.awm.ping', [
     responseHandler(() =>
       Response.ok({
         status: 'advanced wallet manager server is ok!',
@@ -66,7 +72,7 @@ export function createHealthCheckRouter(): WrappedRouter<typeof HealthCheckApiSp
   ]);
 
   // Version endpoint handler
-  router.get('v1.health.version', [
+  router.get('advancedwallet.awm.version', [
     responseHandler(() =>
       Response.ok({
         version: pjson.version,

src/masterBitgoExpress/clients/advancedWalletManagerClient.ts

@@ -346,7 +346,7 @@ export class AdvancedWalletManagerClient {
   async ping(): Promise<PingResponseType> {
     try {
       logger.info('Pinging Advanced Wallet Manager at: %s', this.baseUrl);
-      let request = this.apiClient['v1.health.ping'].post({});
+      let request = this.apiClient['advancedwallet.awm.ping'].post({});
 
       if (this.tlsMode === TlsMode.MTLS) {
         request = request.agent(this.createHttpsAgent());
@@ -371,7 +371,7 @@ export class AdvancedWalletManagerClient {
   async getVersion(): Promise<VersionResponseType> {
     try {
       logger.info('Getting version information from Advanced Wallet Manager');
-      let request = this.apiClient['v1.health.version'].get({});
+      let request = this.apiClient['advancedwallet.awm.version'].get({});
 
       if (this.tlsMode === TlsMode.MTLS) {
         request = request.agent(this.createHttpsAgent());

src/masterBitgoExpress/routers/awmExpressHealth.ts

@@ -30,37 +30,43 @@ const VersionAwmResponse: HttpResponse = {
 };
 
 /**
- * Ping Check
+ * Ping (MBE-to-AWM)
+ *
+ * Test your connection between the Advanced Wallet Manager (AWM) and the Master Bitgo Express (MBE) servers.
+ *
+ * @tag Advanced Wallets
+ * @operationId advancedwallet.ping
+ */
+const PingAwmRoute = httpRoute({
+  method: 'POST',
+  path: '/ping/advancedWalletManager',
+  request: httpRequest({}),
+  response: PingAwmResponse,
+  description: 'Ping the advanced wallet manager server',
+});
+
+/**
+ * Check Version (MBE-to-AWM)
+ *
+ * Use the Master Bitgo Express (MBE) server to check your version of the Advanced Wallet Manager (AWM) server. Calling this endpoint instructs the MBE server to call [Check AWM Version](https://developers.bitgo.com/reference/v1healthversionawm).
  *
  * @tag Advanced Wallets
- * @operationId v1.advancedwalletmanager.ping
- * @private
+ * @operationId advancedwallet.version
  */
+const VersionAwmRoute = httpRoute({
+  method: 'GET',
+  path: '/version/advancedWalletManager',
+  request: httpRequest({}),
+  response: VersionAwmResponse,
+  description: 'Get the version of the advanced wallet manager server',
+});
+
 export const AdvancedWalletManagerHealthSpec = apiSpec({
-  'v1.advancedwalletmanager.ping': {
-    post: httpRoute({
-      method: 'POST',
-      path: '/ping/advancedWalletManager',
-      request: httpRequest({}),
-      response: PingAwmResponse,
-      description: 'Ping the advanced wallet manager server',
-    }),
+  'advancedwallet.ping': {
+    post: PingAwmRoute,
   },
-  /**
-   * Version Check
-   *
-   * @tag Advanced Wallets
-   * @operationId v1.advancedwalletmanager.version
-   * @private
-   */
-  'v1.advancedwalletmanager.version': {
-    get: httpRoute({
-      method: 'GET',
-      path: '/version/advancedWalletManager',
-      request: httpRequest({}),
-      response: VersionAwmResponse,
-      description: 'Get the version of the advanced wallet manager server',
-    }),
+  'advancedwallet.version': {
+    get: VersionAwmRoute,
   },
 });
 
@@ -76,7 +82,7 @@ export function createAdvancedWalletManagerHealthRouter(
   const awmClient = new AdvancedWalletManagerClient(cfg);
 
   // Ping endpoint handler
-  router.post('v1.advancedwalletmanager.ping', [
+  router.post('advancedwallet.ping', [
     responseHandler(async () => {
       logger.debug('Pinging advanced wallet manager');
 
@@ -101,7 +107,7 @@ export function createAdvancedWalletManagerHealthRouter(
     }),
   ]);
 
-  router.get('v1.advancedwalletmanager.version', [
+  router.get('advancedwallet.version', [
     responseHandler(async () => {
       try {
         // Use the client's getVersion method instead of direct HTTP request

src/masterBitgoExpress/routers/healthCheck.ts

@@ -16,37 +16,44 @@ const VersionResponse: HttpResponse = {
 };
 
 /**
- * Ping Check
+ * Ping (MBE)
+ *
+ * Test your connection to the Master Bitgo Express (MBE) server.
  *
  * @tag Advanced Wallets
- * @operationId v1.health.ping
- * @private
+ * @operationId advancedwallet.mbe.ping
  */
+const PingRoute = httpRoute({
+  method: 'POST',
+  path: '/ping',
+  request: httpRequest({}),
+  response: PingResponse,
+  description: 'Health check endpoint that returns server status',
+});
+
+/**
+ * Check Version (MBE)
+ *
+ * Check your version of the Master Bitgo Express (MBE) server.
+ *
+ * @tag Advanced Wallets
+ * @operationId advancedwallet.mbe.version
+ */
+const VersionRoute = httpRoute({
+  method: 'GET',
+  path: '/version',
+  request: httpRequest({}),
+  response: VersionResponse,
+  description: 'Returns the current version of the server',
+});
+
 export const HealthCheckApiSpec = apiSpec({
-  'v1.health.ping': {
-    post: httpRoute({
-      method: 'POST',
-      path: '/ping',
-      request: httpRequest({}),
-      response: PingResponse,
-      description: 'Health check endpoint that returns server status',
-    }),
+  'advancedwallet.mbe.ping': {
+    post: PingRoute,
   },
-  /**
-   * Version Check
-   *
-   * @tag Advanced Wallets
-   * @operationId v1.health.version
-   * @private
-   */
-  'v1.health.version': {
-    get: httpRoute({
-      method: 'GET',
-      path: '/version',
-      request: httpRequest({}),
-      response: VersionResponse,
-      description: 'Returns the current version of the server',
-    }),
+
+  'advancedwallet.mbe.version': {
+    get: VersionRoute,
   },
 });
 
@@ -59,7 +66,7 @@ export function createHealthCheckRouter(
   });
 
   // Ping endpoint handler
-  router.post('v1.health.ping', [
+  router.post('advancedwallet.mbe.ping', [
     responseHandler(() =>
       Response.ok({
         status: `${serverType} server is ok!`,
@@ -69,7 +76,7 @@ export function createHealthCheckRouter(
   ]);
 
   // Version endpoint handler
-  router.get('v1.health.version', [
+  router.get('advancedwallet.mbe.version', [
     responseHandler(() =>
       Response.ok({
         version: pjson.version,