feat(ebe, mbe): added error handling between expresses and kms

Ticket: WP-5241

Author: alextse-bg

src/__tests__/api/enclaved/kmsClient.test.ts

@@ -0,0 +1,90 @@
+import { AppMode, EnclavedConfig, TlsMode } from "../../../initConfig";
+import { app as enclavedApp } from "../../../enclavedApp";
+
+import express from 'express';
+import nock from "nock";
+import * as request from 'supertest';
+import * as sinon from 'sinon';
+import * as configModule from '../../../initConfig';
+
+describe('KMS Client', () => {
+  let cfg: EnclavedConfig;
+  let app: express.Application;
+  let agent: request.SuperAgentTest;
+
+  const kmsUrl = 'https://kms.invalid';
+  const coin = 'hteth';
+  const accessToken = 'test-token';
+
+  let configStub: sinon.SinonStub;
+  
+  before (() => {
+    nock.disableNetConnect();
+    nock.enableNetConnect('127.0.0.1');
+
+    cfg = {
+      appMode: AppMode.ENCLAVED,
+      port: 0, // Let OS assign a free port
+      bind: 'localhost',
+      timeout: 60000,
+      httpLoggerFile: '',
+      kmsUrl: kmsUrl,
+      tlsMode: TlsMode.DISABLED,
+      allowSelfSigned: true,
+      recoveryMode: true,
+    };
+
+    // configStub = sinon.stub(configModule, 'initConfig').returns(cfg);
+
+    // app setup
+    app = enclavedApp(cfg);
+    agent = request.agent(app);
+  });
+
+  after(() => {
+    // configStub.restore();
+  });
+
+  afterEach(() => {
+    nock.cleanAll();
+  });
+
+  it('should bubble up KMS errors', async () => {
+    nock(kmsUrl)
+      .get(/.*/)
+      .reply(400, { message: 'This is an error message' });
+
+    const response = await agent
+      .get(`/api/${coin}/mpcv2/initialize`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send({ source: 'user' });
+
+    console.log(response.body);
+    
+    // response.status.should.equal(400);
+    response.body.should.have.property('error', 'BadRequestError');
+    response.body.should.have.property('details', 'This is an error message');
+  });
+
+  it('should cast unknown KMS error codes into 500', async () => {
+    nock(kmsUrl)
+      .post(/.*/)
+      .reply(418, { error: 'I am a teapot' });
+
+    const response = await agent
+      .post(`/api/${coin}/mpc/sign/mpcv2round1`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send({
+        source: 'user',
+        pub: 'test-pub',
+        txRequest: {},
+        bitgoPublicGpgKey: 'test-bitgo-pub'
+      });
+
+    console.log(response.body);
+
+    // response.status.should.equal(500);
+    response.body.should.have.property('error', 'InternalServerError');
+    response.body.should.have.property('details', 'KMS returned unexpected response. 418: I am a teapot');
+  });
+});