feat(ebe, mbe): added error handling between expresses and kms

Ticket: WP-5241

Author: alextse-bg

src/__tests__/api/enclaved/kmsClient.test.ts

@@ -0,0 +1,57 @@
+import { AppMode, EnclavedConfig, TlsMode } from '../../../initConfig';
+import { app as enclavedApp } from '../../../enclavedApp';
+
+import express from 'express';
+import nock from 'nock';
+import 'should';
+import * as request from 'supertest';
+
+describe('postMpcV2Key', () => {
+  let cfg: EnclavedConfig;
+  let app: express.Application;
+  let agent: request.SuperAgentTest;
+
+  // test config
+  const kmsUrl = 'http://kms.invalid';
+  const coin = 'tsol';
+  const accessToken = 'test-token';
+
+  before(() => {
+    // nock config
+    nock.disableNetConnect();
+    nock.enableNetConnect('127.0.0.1');
+
+    // app config
+    cfg = {
+      appMode: AppMode.ENCLAVED,
+      port: 0, // Let OS assign a free port
+      bind: 'localhost',
+      timeout: 60000,
+      httpLoggerFile: '',
+      kmsUrl: kmsUrl,
+      tlsMode: TlsMode.DISABLED,
+      allowSelfSigned: true,
+    };
+
+    // app setup
+    app = enclavedApp(cfg);
+    agent = request.agent(app);
+  });
+
+  afterEach(() => {
+    nock.cleanAll();
+  });
+
+  it('should bubble up KMS errors', async () => {
+    nock(kmsUrl).post(/.*/).reply(400, { message: 'This is an error message' }).persist();
+
+    const response = await agent
+      .post(`/api/${coin}/mpcv2/initialize`)
+      .set('Authorization', `Bearer ${accessToken}`)
+      .send({ source: 'user' });
+
+    response.status.should.equal(400);
+    response.body.should.have.property('error', 'BadRequestError');
+    response.body.should.have.property('details', 'This is an error message');
+  });
+});

src/__tests__/api/enclaved/recoveryMpcV2.test.ts

@@ -155,7 +155,9 @@ describe('recoveryMpcV2', async () => {
 
     signatureResponse.status.should.equal(400);
     signatureResponse.body.should.have.property('error');
-    signatureResponse.body.error.should.startWith(
+    signatureResponse.body.error.should.equal('BadRequestError');
+    signatureResponse.body.should.have.property('details');
+    signatureResponse.body.details.should.startWith(
       'Failed to construct eth transaction from message hex',
     );
   });

src/__tests__/api/master/recoveryWalletMpcV2.test.ts

@@ -202,7 +202,9 @@ describe('MBE mpcv2 recovery', () => {
 
     response.status.should.equal(422);
     response.body.should.have.property('error');
-    response.body.error.should.equal(
+    response.body.error.should.equal('ValidationError');
+    response.body.should.have.property('details');
+    response.body.details.should.equal(
       'ECDSA ETH-like recovery specific parameters are required for MPC recovery',
     );
   });

src/__tests__/api/master/sendMany.test.ts

@@ -5,7 +5,7 @@ import * as request from 'supertest';
 import nock from 'nock';
 import { app as expressApp } from '../../../masterExpressApp';
 import { AppMode, MasterExpressConfig, TlsMode } from '../../../shared/types';
-import { ApiResponseError, Environments, Wallet } from '@bitgo-beta/sdk-core';
+import { Environments, Wallet } from '@bitgo-beta/sdk-core';
 import { Tbtc } from '@bitgo-beta/sdk-coin-btc';
 import assert from 'assert';
 
@@ -745,14 +745,10 @@ describe('POST /api/:coin/wallet/:walletId/sendmany', () => {
     const verifyStub = sinon.stub(Tbtc.prototype, 'verifyTransaction').resolves(true);
 
     // Mock enclaved express sign request to return an error
-    const signNock = nock(enclavedExpressUrl)
-      .post(`/api/${coin}/multisig/sign`)
-      .replyWithError(
-        new ApiResponseError('Custom API error', 500, {
-          error: 'Custom API error',
-          requestId: 'test-request-id',
-        }),
-      );
+    const signNock = nock(enclavedExpressUrl).post(`/api/${coin}/multisig/sign`).reply(500, {
+      error: 'Internal Server Error',
+      details: 'Custom API error details',
+    });
 
     const response = await agent
       .post(`/api/${coin}/wallet/${walletId}/sendMany`)
@@ -772,11 +768,8 @@ describe('POST /api/:coin/wallet/:walletId/sendmany', () => {
     response.status.should.equal(500);
     response.body.should.have.property('error');
     response.body.should.have.property('details');
-    response.body.error.should.equal('BitGoApiResponseError');
-    response.body.details.should.deepEqual({
-      error: 'Custom API error',
-      requestId: 'test-request-id',
-    });
+    response.body.error.should.equal('Internal Server Error');
+    response.body.details.should.deepEqual('Custom API error details');
 
     walletGetNock.done();
     keychainGetNock.done();