feat: call route handler on eve client for recovery

Author: mtexeira-simtlix

src/api/enclaved/recoveryMultisigTransaction.ts

@@ -1,7 +1,3 @@
-// TODO: based on the original signMultisigTransaction.ts file.
-// Added this one because things like verify transaction doesn't seems to be present during recovery (in my limited experience)
-// But I want to commit something that could be fused later on with the normal signing
-
 import { SignFinalOptions } from '@bitgo/abstract-eth';
 import { MethodNotImplementedError } from 'bitgo';
 import { EnclavedApiSpecRouteRequest } from '../../enclavedBitgoExpress/routers/enclavedApiSpec';

src/masterBitgoExpress/enclavedExpressClient.ts

@@ -1,9 +1,8 @@
-import superagent from 'superagent';
-import https from 'https';
-import debug from 'debug';
-import { MasterExpressConfig } from '../types';
-import { TlsMode } from '../types';
 import { SignedTransaction, TransactionPrebuild } from '@bitgo/sdk-core';
+import debug from 'debug';
+import https from 'https';
+import superagent from 'superagent';
+import { MasterExpressConfig, TlsMode } from '../types';
 
 const debugLogger = debug('bitgo:express:enclavedExpressClient');
 
@@ -29,6 +28,18 @@ interface SignMultisigOptions {
   pub: string;
 }
 
+interface RecoveryMultisigOptions {
+  userPub: string;
+  backupPub: string;
+  walletContractAddress: string;
+  recoveryDestinationAddress: string;
+  apiKey: string;
+  recoveryParams?: {
+    bitgoPub?: string;
+    ignoreAddressTypes: string[];
+  };
+}
+
 export class EnclavedExpressClient {
   private readonly baseUrl: string;
   private readonly enclavedExpressCert: string;
@@ -134,6 +145,27 @@ export class EnclavedExpressClient {
       throw err;
     }
   }
+
+  /**
+   * Recovery a multisig transaction
+   */
+  async recoveryMultisig(params: RecoveryMultisigOptions): Promise<SignedTransaction> {
+    if (!this.coin) {
+      throw new Error('Coin must be specified to recovery a multisig');
+    }
+
+    try {
+      const res = await this.configureRequest(
+        superagent.post(`${this.baseUrl}/api/${this.coin}/multisig/recovery`).type('json'),
+      ).send(params);
+
+      return res.body;
+    } catch (error) {
+      const err = error as Error;
+      debugLogger('Failed to recover multisig: %s', err.message);
+      throw err;
+    }
+  }
 }
 
 /**

src/masterBitgoExpress/recoveryWallet.ts

@@ -28,12 +28,11 @@ export async function handleRecoveryWalletOnPrem(
   } = req.body;
 
   try {
-    const fullSignedRecoveryTx = await enclavedExpressClient.multisigRecovery({
-      coin,
+    const fullSignedRecoveryTx = await enclavedExpressClient.recoveryMultisig({
       userPub,
       backupPub,
       walletContractAddress,
-      recoveryDestination: recoveryDestinationAddress,
+      recoveryDestinationAddress,
       apiKey,
       recoveryParams,
     });