Merge pull request #82 from BitGo/WP-5339-more-config-tests

chore(mbe): clean up / consolidate configs for mbe/ebe

Author: pranavjain97

README.md

@@ -75,8 +75,7 @@ Both modes use the same TLS configuration variables:
 
 ### Logging and Debug
 
-- `LOGFILE` - Path to log file (optional)
-- `DEBUG_NAMESPACE` - Debug namespaces to enable (e.g., 'enclaved:\*')
+- `HTTP_LOGFILE` - Path to HTTP request log file (optional, used by Morgan for HTTP access logs)
 
 ## Quick Start
 
@@ -232,6 +231,7 @@ curl -k -X POST https://localhost:3081/ping/enclavedExpress
 ```
 
 Notes:
+
 - `host.containers.internal` is a special DNS name that resolves to the host machine from inside containers
 - The `:Z` option in volume mounts is specific to SELinux-enabled systems and ensures proper volume labeling
 - The logs directory will be created with appropriate permissions if it doesn't exist

src/__tests__/api/enclaved/postIndependentKey.test.ts

@@ -33,10 +33,9 @@ describe('postIndependentKey', () => {
       port: 0, // Let OS assign a free port
       bind: 'localhost',
       timeout: 60000,
-      logFile: '',
+      httpLoggerFile: '',
       kmsUrl: kmsUrl,
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };
 

src/__tests__/api/enclaved/postMpcV2Key.test.ts

@@ -35,10 +35,9 @@ describe('postMpcV2Key', () => {
       port: 0, // Let OS assign a free port
       bind: 'localhost',
       timeout: 60000,
-      logFile: '',
+      httpLoggerFile: '',
       kmsUrl: kmsUrl,
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };
 

src/__tests__/api/enclaved/recoveryMultisigTransaction.test.ts

@@ -18,9 +18,8 @@ describe('UTXO recovery', () => {
     port: 0,
     bind: 'localhost',
     timeout: 60000,
-    logFile: '',
+    httpLoggerFile: '',
     tlsMode: TlsMode.DISABLED,
-    mtlsRequestCert: false,
     allowSelfSigned: true,
     kmsUrl: 'kms.example.com',
   };

src/__tests__/api/enclaved/recoveryMusigEth.test.ts

@@ -36,10 +36,9 @@ describe('recoveryMultisigTransaction', () => {
       port: 0, // Let OS assign a free port
       bind: 'localhost',
       timeout: 60000,
-      logFile: '',
+      httpLoggerFile: '',
       kmsUrl: kmsUrl,
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };
 

src/__tests__/api/enclaved/signMpcRecoveryTransaction.test.ts

@@ -10,15 +10,14 @@ import { AppMode, EnclavedConfig, TlsMode } from '../../../shared/types';
 describe('EdDSA Recovery Signing', () => {
   let agent: supertest.SuperTest<supertest.Test>;
   const config: EnclavedConfig = {
+    kmsUrl: 'http://localhost:3000',
     appMode: AppMode.ENCLAVED,
     port: 0,
     bind: 'localhost',
     timeout: 60000,
-    logFile: '',
+    httpLoggerFile: '',
     tlsMode: TlsMode.DISABLED,
-    mtlsRequestCert: false,
     allowSelfSigned: true,
-    kmsUrl: 'kms.example.com',
   };
 
   const commonKeychain =

src/__tests__/api/enclaved/signMpcTransaction.test.ts

@@ -40,10 +40,9 @@ describe('signMpcTransaction', () => {
       port: 0, // Let OS assign a free port
       bind: 'localhost',
       timeout: 60000,
-      logFile: '',
+      httpLoggerFile: '',
       kmsUrl: kmsUrl,
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };
 

src/__tests__/api/enclaved/signMultisigTransaction.test.ts

@@ -33,10 +33,9 @@ describe('signMultisigTransaction', () => {
       port: 0, // Let OS assign a free port
       bind: 'localhost',
       timeout: 60000,
-      logFile: '',
+      httpLoggerFile: '',
       kmsUrl: kmsUrl,
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };
 

src/__tests__/api/master/accelerate.test.ts

@@ -23,14 +23,13 @@ describe('POST /api/:coin/wallet/:walletId/accelerate', () => {
       port: 0, // Let OS assign a free port
       bind: 'localhost',
       timeout: 30000,
-      logFile: '',
+      httpLoggerFile: '',
       env: 'test',
       disableEnvCheck: true,
       authVersion: 2,
       enclavedExpressUrl: enclavedExpressUrl,
       enclavedExpressCert: 'test-cert',
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };
 

src/__tests__/api/master/consolidate.test.ts

@@ -26,14 +26,13 @@ describe('POST /api/:coin/wallet/:walletId/consolidateunspents', () => {
       port: 0,
       bind: 'localhost',
       timeout: 30000,
-      logFile: '',
+      httpLoggerFile: '',
       env: 'test',
       disableEnvCheck: true,
       authVersion: 2,
       enclavedExpressUrl: enclavedExpressUrl,
       enclavedExpressCert: 'test-cert',
       tlsMode: TlsMode.DISABLED,
-      mtlsRequestCert: false,
       allowSelfSigned: true,
     };