Merge pull request #60 from BitGo/WP-000000/mpcv2-create-follow-up

chore: refactor file names for mpc creation

Author: pranavjain97

…c/api/enclaved/handlers/mpcV2Finalize.ts …/enclaved/handlers/ecdsaMPCv2Finalize.tssrc/api/enclaved/handlers/mpcV2Finalize.ts renamed to src/api/enclaved/handlers/ecdsaMPCv2Finalize.ts src/api/enclaved/handlers/mpcV2Finalize.ts renamed to src/api/enclaved/handlers/ecdsaMPCv2Finalize.ts

@@ -7,7 +7,7 @@ import {
 import { KmsClient } from '../../../kms/kmsClient';
 import assert from 'assert';
 
-export async function mpcV2Finalize(
+export async function ecdsaMPCv2Finalize(
   req: EnclavedApiSpecRouteRequest<'v1.mpcv2.finalize', 'post'>,
 ): Promise<MpcV2FinalizeResponseType> {
   const { source, encryptedData, encryptedDataKey, broadcastMessages, bitgoCommonKeychain } =

…api/enclaved/handlers/mpcV2Initialize.ts …nclaved/handlers/ecdsaMPCv2Initialize.tssrc/api/enclaved/handlers/mpcV2Initialize.ts renamed to src/api/enclaved/handlers/ecdsaMPCv2Initialize.ts src/api/enclaved/handlers/mpcV2Initialize.ts renamed to src/api/enclaved/handlers/ecdsaMPCv2Initialize.ts

@@ -8,7 +8,7 @@ import * as bitgoSdk from '@bitgo/sdk-core';
 import logger from '../../../logger';
 import { MPCv2PartiesEnum } from '@bitgo/sdk-core/dist/src/bitgo/utils/tss/ecdsa';
 
-export async function mpcV2Initialize(
+export async function ecdsaMPCv2Initialize(
   req: EnclavedApiSpecRouteRequest<'v1.mpcv2.initialize', 'post'>,
 ): Promise<MpcV2InitializeResponseType> {
   const { source } = req.decoded;

src/api/enclaved/handlers/mpcV2Round.ts …api/enclaved/handlers/ecdsaMPCv2Round.tssrc/api/enclaved/handlers/mpcV2Round.ts renamed to src/api/enclaved/handlers/ecdsaMPCv2Round.ts src/api/enclaved/handlers/mpcV2Round.ts renamed to src/api/enclaved/handlers/ecdsaMPCv2Round.ts

@@ -7,7 +7,7 @@ import {
 import { MPCv2PartiesEnum } from '@bitgo/sdk-core/dist/src/bitgo/utils/tss/ecdsa';
 import { KmsClient } from '../../../kms/kmsClient';
 
-export async function mpcV2Round(
+export async function ecdsaMPCv2Round(
   req: EnclavedApiSpecRouteRequest<'v1.mpcv2.round', 'post'>,
 ): Promise<MpcV2RoundResponseType> {
   const { source, encryptedData, encryptedDataKey, round, broadcastMessages, p2pMessages } =

src/api/master/clients/enclavedExpressClient.ts

@@ -508,7 +508,9 @@ export class EnclavedExpressClient {
   /**
    * Initialize MPCv2 key generation
    */
-  async initMpcV2(params: { source: 'user' | 'backup' }): Promise<MpcV2InitializeResponseType> {
+  async initEcdsaMpcV2KeyGenMpcV2(params: {
+    source: 'user' | 'backup';
+  }): Promise<MpcV2InitializeResponseType> {
     if (!this.coin) {
       throw new Error('Coin must be specified to initialize MPCv2 key generation');
     }
@@ -536,7 +538,7 @@ export class EnclavedExpressClient {
   /**
    * Execute a round in the MPCv2 protocol
    */
-  async mpcV2Round(params: {
+  async roundEcdsaMPCv2KeyGen(params: {
     source: 'user' | 'backup';
     encryptedData: string;
     encryptedDataKey: string;
@@ -573,7 +575,7 @@ export class EnclavedExpressClient {
   /**
    * Finalize MPCv2 key generation
    */
-  async mpcV2Finalize(params: {
+  async finalizeEcdsaMPCv2KeyGen(params: {
     source: 'user' | 'backup';
     encryptedData: string;
     encryptedDataKey: string;

src/api/master/handlers/ecdsa.ts

@@ -1,11 +1,13 @@
 import {
+  BaseCoin,
   BitGoBase,
+  commonTssMethods,
+  EcdsaMPCv2Utils,
   getTxRequest,
-  Wallet,
   IRequestTracer,
-  EcdsaMPCv2Utils,
-  commonTssMethods,
   RequestType,
+  SupplementGenerateWalletOptions,
+  Wallet,
 } from '@bitgo/sdk-core';
 import { EnclavedExpressClient } from '../clients/enclavedExpressClient';
 import logger from '../../../logger';
@@ -113,3 +115,286 @@ export async function handleEcdsaSigning(
     reqId,
   );
 }
+
+interface OrchestrateEcdsaKeyGenParams {
+  bitgo: BitGoBase;
+  baseCoin: BaseCoin;
+  enclavedExpressClient: EnclavedExpressClient;
+  enterprise: string;
+  walletParams: SupplementGenerateWalletOptions;
+}
+
+export async function orchestrateEcdsaKeyGen({
+  bitgo,
+  baseCoin,
+  enclavedExpressClient,
+  enterprise,
+  walletParams,
+}: OrchestrateEcdsaKeyGenParams) {
+  const constants = await bitgo.fetchConstants();
+  if (!constants.mpc.bitgoMPCv2PublicKey) {
+    throw new Error('Unable to create MPCv2 keys - bitgoMPCv2PublicKey is missing in constants');
+  }
+  const ecdsaUtils = new EcdsaMPCv2Utils(bitgo, baseCoin);
+
+  // INITIALIZE ROUND: GENERATE ALL GPG KEYS AND RETRIEVE GPG PUBS FROM ALL PARTIES
+  const userInitResponse = await enclavedExpressClient.initEcdsaMpcV2KeyGenMpcV2({
+    source: 'user',
+  });
+  if (
+    !userInitResponse.gpgPub ||
+    !userInitResponse.encryptedData ||
+    !userInitResponse.encryptedDataKey
+  ) {
+    throw new Error('Missing required fields in user init response');
+  }
+  const backupInitResponse = await enclavedExpressClient.initEcdsaMpcV2KeyGenMpcV2({
+    source: 'backup',
+  });
+  if (
+    !backupInitResponse.gpgPub ||
+    !backupInitResponse.encryptedData ||
+    !backupInitResponse.encryptedDataKey
+  ) {
+    throw new Error('Missing required fields in backup init response');
+  }
+
+  // ROUND 1
+  const userRound1Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'user',
+    encryptedData: userInitResponse.encryptedData,
+    encryptedDataKey: userInitResponse.encryptedDataKey,
+    round: 1,
+    bitgoGpgPub: constants.mpc.bitgoMPCv2PublicKey,
+    counterPartyGpgPub: backupInitResponse.gpgPub,
+  });
+  const backupRound1Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'backup',
+    encryptedData: backupInitResponse.encryptedData,
+    encryptedDataKey: backupInitResponse.encryptedDataKey,
+    round: 1,
+    bitgoGpgPub: constants.mpc.bitgoMPCv2PublicKey,
+    counterPartyGpgPub: userInitResponse.gpgPub,
+  });
+  const [userRound1Response, backupRound1Response] = await Promise.all([
+    userRound1Promise,
+    backupRound1Promise,
+  ]);
+  if (!userRound1Response.broadcastMessage) {
+    throw new Error('Missing broadcast message in user round 1 response');
+  }
+  if (!backupRound1Response.broadcastMessage) {
+    throw new Error('Missing broadcast message in backup round 1 response');
+  }
+
+  // ROUND 1 & 2 BitGo
+  const round1And2BitGoResponse = await ecdsaUtils.sendKeyGenerationRound1(
+    enterprise,
+    userInitResponse.gpgPub,
+    backupInitResponse.gpgPub,
+    {
+      broadcastMessages: [
+        userRound1Response.broadcastMessage,
+        backupRound1Response.broadcastMessage,
+      ],
+      p2pMessages: [],
+    },
+  );
+  const { sessionId, bitgoMsg1, bitgoToUserMsg2, bitgoToBackupMsg2 } = round1And2BitGoResponse;
+
+  // ROUND 2
+  const userRound2Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'user',
+    encryptedData: userRound1Response.encryptedData,
+    encryptedDataKey: userRound1Response.encryptedDataKey,
+    round: 2,
+    broadcastMessages: {
+      bitgo: ecdsaUtils.formatBitgoBroadcastMessage(bitgoMsg1),
+      counterParty: backupRound1Response.broadcastMessage,
+    },
+  });
+  const backupRound2Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'backup',
+    encryptedData: backupRound1Response.encryptedData,
+    encryptedDataKey: backupRound1Response.encryptedDataKey,
+    round: 2,
+    broadcastMessages: {
+      bitgo: ecdsaUtils.formatBitgoBroadcastMessage(bitgoMsg1),
+      counterParty: userRound1Response.broadcastMessage,
+    },
+  });
+  const [userRound2Response, backupRound2Response] = await Promise.all([
+    userRound2Promise,
+    backupRound2Promise,
+  ]);
+  if (!userRound2Response.p2pMessages?.bitgo) {
+    throw new Error('Missing BitGo p2p message in user round 2 response');
+  }
+  if (!backupRound2Response.p2pMessages?.bitgo) {
+    throw new Error('Missing BitGo p2p message in backup round 2 response');
+  }
+
+  // ROUND 3
+  const userRound3Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'user',
+    encryptedData: userRound2Response.encryptedData,
+    encryptedDataKey: userRound2Response.encryptedDataKey,
+    round: 3,
+    p2pMessages: {
+      bitgo: ecdsaUtils.formatP2PMessage(bitgoToUserMsg2),
+      counterParty: backupRound2Response.p2pMessages?.counterParty,
+    },
+  });
+  const backupRound3Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'backup',
+    encryptedData: backupRound2Response.encryptedData,
+    encryptedDataKey: backupRound2Response.encryptedDataKey,
+    round: 3,
+    p2pMessages: {
+      bitgo: ecdsaUtils.formatP2PMessage(bitgoToBackupMsg2),
+      counterParty: userRound2Response.p2pMessages?.counterParty,
+    },
+  });
+  const round3BitGoPromise = ecdsaUtils.sendKeyGenerationRound2(enterprise, sessionId, {
+    p2pMessages: [
+      userRound2Response.p2pMessages?.bitgo,
+      backupRound2Response.p2pMessages?.bitgo,
+    ].filter((msg) => msg !== undefined),
+    broadcastMessages: [],
+  });
+  const [userRound3Response, backupRound3Response, round3BitGoResponse] = await Promise.all([
+    userRound3Promise,
+    backupRound3Promise,
+    round3BitGoPromise,
+  ]);
+  const {
+    sessionId: sessionIdRound3,
+    bitgoToUserMsg3,
+    bitgoToBackupMsg3,
+    bitgoCommitment2: bitgoCommitment3,
+  } = round3BitGoResponse;
+  if (!userRound3Response.p2pMessages?.bitgo) {
+    throw new Error('Missing BitGo p2p message in user round 3 response');
+  }
+  if (!backupRound3Response.p2pMessages?.bitgo) {
+    throw new Error('Missing BitGo p2p message in backup round 3 response');
+  }
+  if (sessionId !== sessionIdRound3) {
+    throw new Error('Round 1 and 2 Session IDs do not match');
+  }
+
+  // ROUND 4
+  const userRound4Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'user',
+    encryptedData: userRound3Response.encryptedData,
+    encryptedDataKey: userRound3Response.encryptedDataKey,
+    round: 4,
+    p2pMessages: {
+      bitgo: ecdsaUtils.formatP2PMessage(bitgoToUserMsg3, bitgoCommitment3),
+      counterParty: backupRound3Response.p2pMessages?.counterParty,
+    },
+  });
+  const backupRound4Promise = enclavedExpressClient.roundEcdsaMPCv2KeyGen({
+    source: 'backup',
+    encryptedData: backupRound3Response.encryptedData,
+    encryptedDataKey: backupRound3Response.encryptedDataKey,
+    round: 4,
+    p2pMessages: {
+      bitgo: ecdsaUtils.formatP2PMessage(bitgoToBackupMsg3, bitgoCommitment3),
+      counterParty: userRound3Response.p2pMessages?.counterParty,
+    },
+  });
+  const [userRound4Response, backupRound4Response] = await Promise.all([
+    userRound4Promise,
+    backupRound4Promise,
+  ]);
+  if (!userRound4Response.broadcastMessage) {
+    throw new Error('Missing broadcast message in user round 4 response');
+  }
+  if (!backupRound4Response.broadcastMessage) {
+    throw new Error('Missing broadcast message in backup round 4 response');
+  }
+
+  // FINALIZE
+  const round4BitGoResponse = await ecdsaUtils.sendKeyGenerationRound3(enterprise, sessionId, {
+    p2pMessages: [
+      userRound3Response.p2pMessages?.bitgo,
+      backupRound3Response.p2pMessages?.bitgo,
+    ].filter((msg) => msg !== undefined),
+    broadcastMessages: [
+      userRound4Response.broadcastMessage,
+      backupRound4Response.broadcastMessage,
+    ].filter((msg) => msg !== undefined),
+  });
+  const {
+    sessionId: sessionIdRound4,
+    bitgoMsg4,
+    commonKeychain: bitgoCommonKeychain,
+  } = round4BitGoResponse;
+  const userFinalizePromise = enclavedExpressClient.finalizeEcdsaMPCv2KeyGen({
+    source: 'user',
+    encryptedData: userRound4Response.encryptedData,
+    encryptedDataKey: userRound4Response.encryptedDataKey,
+    broadcastMessages: {
+      bitgo: ecdsaUtils.formatBitgoBroadcastMessage(bitgoMsg4),
+      counterParty: backupRound4Response.broadcastMessage,
+    },
+    bitgoCommonKeychain,
+  });
+  const backupFinalizePromise = enclavedExpressClient.finalizeEcdsaMPCv2KeyGen({
+    source: 'backup',
+    encryptedData: backupRound4Response.encryptedData,
+    encryptedDataKey: backupRound4Response.encryptedDataKey,
+    broadcastMessages: {
+      bitgo: ecdsaUtils.formatBitgoBroadcastMessage(bitgoMsg4),
+      counterParty: userRound4Response.broadcastMessage,
+    },
+    bitgoCommonKeychain,
+  });
+  const [userFinalizeResponse, backupFinalizeResponse] = await Promise.all([
+    userFinalizePromise,
+    backupFinalizePromise,
+  ]);
+  if (sessionId !== sessionIdRound4) {
+    throw new Error('Round 4 Session IDs do not match');
+  }
+  if (!userFinalizeResponse.commonKeychain) {
+    throw new Error('Missing common keychain in user finalize response');
+  }
+  if (!backupFinalizeResponse.commonKeychain) {
+    throw new Error('Missing common keychain in backup finalize response');
+  }
+  if (userFinalizeResponse.commonKeychain !== backupFinalizeResponse.commonKeychain) {
+    throw new Error('User and backup common keychains do not match');
+  }
+  if (userFinalizeResponse.commonKeychain !== bitgoCommonKeychain) {
+    throw new Error('User and BitGo common keychains do not match');
+  }
+
+  // CREATE KEYCHAINS
+  const userMpcKey = await baseCoin.keychains().add({
+    commonKeychain: userFinalizeResponse.commonKeychain,
+    source: 'user',
+    type: 'tss',
+    isMPCv2: true,
+  });
+  const backupMpcKey = await baseCoin.keychains().add({
+    commonKeychain: backupFinalizeResponse.commonKeychain,
+    source: 'backup',
+    type: 'tss',
+    isMPCv2: true,
+  });
+  const bitgoKeychain = await baseCoin.keychains().add({
+    commonKeychain: bitgoCommonKeychain,
+    source: 'bitgo',
+    type: 'tss',
+    isMPCv2: true,
+  });
+  walletParams.keys = [userMpcKey.id, backupMpcKey.id, bitgoKeychain.id];
+  const keychains = {
+    userKeychain: userMpcKey,
+    backupKeychain: backupMpcKey,
+    bitgoKeychain,
+  };
+  return { walletParams, keychains };
+}