Skip to content

Commit 824a322

Browse files
feat(mbe): hide recovery apis under non recovery mode for mbe
1 parent 57eaca1 commit 824a322

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

src/__tests__/api/master/musigRecovery.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ describe('POST /api/:coin/wallet/recovery', () => {
3232
tlsMode: TlsMode.DISABLED,
3333
mtlsRequestCert: false,
3434
allowSelfSigned: true,
35-
recoveryMode: true
35+
recoveryMode: true,
3636
};
3737

3838
const app = expressApp(config);

src/__tests__/api/master/nonRecovery.test.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@ import * as masterMiddleware from '../../../api/master/middleware/middleware';
99
import { BitGoRequest } from '../../../types/request';
1010
import { BitGoAPI } from '@bitgo-beta/sdk-api';
1111
import { EnclavedExpressClient } from '../../../api/master/clients/enclavedExpressClient';
12-
import { CoinFamily } from '@bitgo-beta/statics';
13-
import { Trx } from '@bitgo-beta/sdk-coin-trx';
1412

1513
describe('Non Recovery Tests', () => {
1614
let agent: request.SuperAgentTest;
1715
let mockBitgo: BitGoAPI;
18-
let coinStub: sinon.SinonStub;
1916
const enclavedExpressUrl = 'http://enclaved.invalid';
2017
const accessToken = 'test-token';
2118
const config: MasterExpressConfig = {
@@ -71,8 +68,6 @@ describe('Non Recovery Tests', () => {
7168
register: sinon.stub(),
7269
} as unknown as BitGoAPI;
7370

74-
coinStub = mockBitgo.coin as sinon.SinonStub;
75-
7671
// Setup middleware stubs before creating app
7772
sinon.stub(middleware, 'prepareBitGo').callsFake(() => (req, res, next) => {
7873
(req as BitGoRequest<MasterExpressConfig>).bitgo = mockBitgo;
@@ -132,7 +127,9 @@ describe('Non Recovery Tests', () => {
132127
response.status.should.equal(500);
133128
response.body.should.have.property('error');
134129
response.body.should.have.property('details');
135-
response.body.details.should.containEql('Recovery operations are not enabled. The server must be in recovery mode to perform this action.');
130+
response.body.details.should.containEql(
131+
'Recovery operations are not enabled. The server must be in recovery mode to perform this action.',
132+
);
136133
});
137134
});
138135

src/__tests__/api/master/recoveryConsolidationsWallet.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ describe('POST /api/:coin/wallet/recoveryconsolidations', () => {
3131
tlsMode: TlsMode.DISABLED,
3232
mtlsRequestCert: false,
3333
allowSelfSigned: true,
34-
recoveryMode: true
34+
recoveryMode: true,
3535
};
3636
const app = expressApp(config);
3737
agent = request.agent(app);

src/api/master/handlerUtils.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ export function makeCustomSigningFunction({
7777

7878
export function checkRecoveryMode(config: MasterExpressConfig) {
7979
if (!config.recoveryMode) {
80-
throw new Error('Recovery operations are not enabled. The server must be in recovery mode to perform this action.');
80+
throw new Error(
81+
'Recovery operations are not enabled. The server must be in recovery mode to perform this action.',
82+
);
8183
}
82-
}
84+
}

src/api/master/handlers/recoveryWallet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export async function handleRecoveryWalletOnPrem(
188188
req: MasterApiSpecRouteRequest<'v1.wallet.recovery', 'post'>,
189189
) {
190190
checkRecoveryMode(req.config as MasterExpressConfig);
191-
191+
192192
const bitgo = req.bitgo;
193193
const coin = req.decoded.coin;
194194
const enclavedExpressClient = req.enclavedExpressClient;

0 commit comments

Comments
 (0)