fix: move verifyTransaction from ebe to mbe

Ticket: WP-4689

Author: pranavjain97

src/api/enclaved/signMultisigTransaction.ts

@@ -14,32 +14,13 @@ export async function signMultisigTransaction(
 
   if (!source || !pub) {
     throw new Error('Source and public key are required for signing');
-  } else if (!txPrebuild || !txPrebuild.wallet) {
+  } else if (!txPrebuild) {
     throw new Error('Transaction prebuild is required for signing');
   }
 
-  const reqId = new RequestTracer();
   const bitgo = req.bitgo;
-  const baseCoin = bitgo.coin(req.params.coin);
   const kms = new KmsClient();
 
-  // verify transaction prebuild
-  try {
-    await baseCoin.verifyTransaction({
-      txParams: { ...txPrebuild.buildParams },
-      txPrebuild,
-      wallet: txPrebuild.wallet,
-      verification: {},
-      reqId: reqId,
-      walletType: 'onchain',
-    });
-  } catch (e) {
-    const err = e as Error;
-    logger.error('transaction prebuild failed local validation:', err.message);
-    logger.error('transaction prebuild:', JSON.stringify(txPrebuild, null, 2));
-    logger.error(err);
-  }
-
   // Retrieve the private key from KMS
   let prv: string;
   try {

src/masterBitgoExpress/handleSendMany.ts

@@ -52,22 +52,47 @@ export async function handleSendMany(req: MasterApiSpecRouteRequest<'v1.wallet.s
     throw new Error(`Signing keychain for ${params.source} not found`);
   }
 
+  logger.debug(`Signing keychain: ${JSON.stringify(signingKeychain, null, 2)}`);
+
   try {
     const prebuildParams: PrebuildTransactionOptions = {
       ...params,
       // Convert memo string to Memo object if present
       memo: params.memo ? ({ type: 'text', value: params.memo } as Memo) : undefined,
     };
 
-    // First build the transaction
-    const txPrebuild = await wallet.prebuildTransaction({
+    // First build the transaction with bitgo
+    const txPrebuilt = await wallet.prebuildTransaction({
       ...prebuildParams,
       reqId,
     });
 
+    // verify transaction prebuild
+    try {
+      const verified = await baseCoin.verifyTransaction({
+        txParams: { ...prebuildParams },
+        txPrebuild: txPrebuilt,
+        wallet,
+        verification: {},
+        reqId: reqId,
+        walletType: 'onchain',
+      });
+      if (!verified) {
+        throw new Error('Transaction prebuild failed local validation');
+      }
+      logger.debug('Transaction prebuild verified');
+    } catch (e) {
+      const err = e as Error;
+      logger.error('transaction prebuild failed local validation:', err.message);
+      logger.error('transaction prebuild:', JSON.stringify(txPrebuilt, null, 2));
+      logger.error(err);
+    }
+
+    logger.debug('Tx prebuild: %s', JSON.stringify(txPrebuilt, null, 2));
+
     // Then sign it using the enclaved express client
     const signedTx = await enclavedExpressClient.signMultisig({
-      txPrebuild,
+      txPrebuild: txPrebuilt,
       source: params.source,
       pub: signingKeychain.pub,
     });