Skip to content

Commit 9a50212

Browse files
committed
docs: Refined ts code and cleaned up JS Doc
Ticket: TW-138
1 parent 031e5b1 commit 9a50212

File tree

12 files changed

+113
-94
lines changed

12 files changed

+113
-94
lines changed

src/advancedWalletManager/routers/healthCheck.ts

Lines changed: 34 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,43 @@ const VersionResponse: HttpResponse = {
1616
};
1717

1818
/**
19-
* Ping Check
19+
* Ping (AWM)
20+
*
21+
* Test your connection to the Advanced Wallet Manager (AWM) server.
22+
*
23+
* @tag Advanced Wallets
24+
* @operationId advancedwallet.awm.ping
25+
*/
26+
const PingRoute = httpRoute({
27+
method: 'POST',
28+
path: '/ping',
29+
request: httpRequest({}),
30+
response: PingResponse,
31+
description: 'Health check endpoint that returns server status',
32+
});
33+
34+
/**
35+
* Check Version (AWM)
36+
*
37+
* Check your version of the Advanced Wallet Manager (AWM) server.
2038
*
2139
* @tag Advanced Wallets
22-
* @operationId v1.health.ping
23-
* @private
40+
* @operationId advancedwallet.awm.version
2441
*/
42+
const VersionRoute = httpRoute({
43+
method: 'GET',
44+
path: '/version',
45+
request: httpRequest({}),
46+
response: VersionResponse,
47+
description: 'Returns the current version of the server',
48+
});
49+
2550
export const HealthCheckApiSpec = apiSpec({
26-
'v1.health.ping': {
27-
post: httpRoute({
28-
method: 'POST',
29-
path: '/ping',
30-
request: httpRequest({}),
31-
response: PingResponse,
32-
description: 'Health check endpoint that returns server status',
33-
}),
51+
'advancedwallet.awm.ping': {
52+
post: PingRoute,
3453
},
35-
/**
36-
* Version Check
37-
*
38-
* @tag Advanced Wallets
39-
* @operationId v1.health.version
40-
* @private
41-
*/
42-
'v1.health.version': {
43-
get: httpRoute({
44-
method: 'GET',
45-
path: '/version',
46-
request: httpRequest({}),
47-
response: VersionResponse,
48-
description: 'Returns the current version of the server',
49-
}),
54+
'advancedwallet.awm.version': {
55+
get: VersionRoute,
5056
},
5157
});
5258

@@ -56,7 +62,7 @@ export function createHealthCheckRouter(): WrappedRouter<typeof HealthCheckApiSp
5662
decodeErrorFormatter: customDecodeErrorFormatter,
5763
});
5864
// Ping endpoint handler
59-
router.post('v1.health.ping', [
65+
router.post('advancedwallet.awm.ping', [
6066
responseHandler(() =>
6167
Response.ok({
6268
status: 'advanced wallet manager server is ok!',
@@ -66,7 +72,7 @@ export function createHealthCheckRouter(): WrappedRouter<typeof HealthCheckApiSp
6672
]);
6773

6874
// Version endpoint handler
69-
router.get('v1.health.version', [
75+
router.get('advancedwallet.awm.version', [
7076
responseHandler(() =>
7177
Response.ok({
7278
version: pjson.version,

src/masterBitgoExpress/clients/advancedWalletManagerClient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ export class AdvancedWalletManagerClient {
346346
async ping(): Promise<PingResponseType> {
347347
try {
348348
logger.info('Pinging Advanced Wallet Manager at: %s', this.baseUrl);
349-
let request = this.apiClient['v1.health.ping'].post({});
349+
let request = this.apiClient['advancedwallet.awm.ping'].post({});
350350

351351
if (this.tlsMode === TlsMode.MTLS) {
352352
request = request.agent(this.createHttpsAgent());
@@ -371,7 +371,7 @@ export class AdvancedWalletManagerClient {
371371
async getVersion(): Promise<VersionResponseType> {
372372
try {
373373
logger.info('Getting version information from Advanced Wallet Manager');
374-
let request = this.apiClient['v1.health.version'].get({});
374+
let request = this.apiClient['advancedwallet.awm.version'].get({});
375375

376376
if (this.tlsMode === TlsMode.MTLS) {
377377
request = request.agent(this.createHttpsAgent());

src/masterBitgoExpress/routers/accelerateRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ const AccelerateResponse: HttpResponse = {
8383
* Use this endpoint only with advanced wallets. For other wallet types, use [Accelerate Transaction](https://developers.bitgo.com/reference/expresswalletacceleratetx).
8484
*
8585
* @tag Advanced Wallets
86-
* @operationId advancedwalletacceleratetx
86+
* @operationId advancedwallet.accelerate.tx
8787
*/
8888
export const AccelerateRoute = httpRoute({
8989
method: 'POST',

src/masterBitgoExpress/routers/awmExpressHealth.ts

Lines changed: 34 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -30,37 +30,43 @@ const VersionAwmResponse: HttpResponse = {
3030
};
3131

3232
/**
33-
* Ping Check
33+
* Ping (MBE-to-AWM)
34+
*
35+
* Test your connection between the Advanced Wallet Manager (AWM) and the Master Bitgo Express (MBE) servers.
36+
*
37+
* @tag Advanced Wallets
38+
* @operationId advancedwallet.mbe.awm.ping
39+
*/
40+
const PingAwmRoute = httpRoute({
41+
method: 'POST',
42+
path: '/ping/advancedWalletManager',
43+
request: httpRequest({}),
44+
response: PingAwmResponse,
45+
description: 'Ping the advanced wallet manager server',
46+
});
47+
48+
/**
49+
* Check Version (MBE-to-AWM)
50+
*
51+
* Use the Master Bitgo Express (MBE) server to check your version of the Advanced Wallet Manager (AWM) server. Calling this endpoint instructs the MBE server to call [Check AWM Version](https://developers.bitgo.com/reference/v1healthversionawm).
3452
*
3553
* @tag Advanced Wallets
36-
* @operationId v1.advancedwalletmanager.ping
37-
* @private
54+
* @operationId advancedwallet.mbe.awm.version
3855
*/
56+
const VersionAwmRoute = httpRoute({
57+
method: 'GET',
58+
path: '/version/advancedWalletManager',
59+
request: httpRequest({}),
60+
response: VersionAwmResponse,
61+
description: 'Get the version of the advanced wallet manager server',
62+
});
63+
3964
export const AdvancedWalletManagerHealthSpec = apiSpec({
40-
'v1.advancedwalletmanager.ping': {
41-
post: httpRoute({
42-
method: 'POST',
43-
path: '/ping/advancedWalletManager',
44-
request: httpRequest({}),
45-
response: PingAwmResponse,
46-
description: 'Ping the advanced wallet manager server',
47-
}),
65+
'advancedwallet.mbe.awm.ping': {
66+
post: PingAwmRoute,
4867
},
49-
/**
50-
* Version Check
51-
*
52-
* @tag Advanced Wallets
53-
* @operationId v1.advancedwalletmanager.version
54-
* @private
55-
*/
56-
'v1.advancedwalletmanager.version': {
57-
get: httpRoute({
58-
method: 'GET',
59-
path: '/version/advancedWalletManager',
60-
request: httpRequest({}),
61-
response: VersionAwmResponse,
62-
description: 'Get the version of the advanced wallet manager server',
63-
}),
68+
'advancedwallet.mbe.awm.version': {
69+
get: VersionAwmRoute,
6470
},
6571
});
6672

@@ -76,7 +82,7 @@ export function createAdvancedWalletManagerHealthRouter(
7682
const awmClient = new AdvancedWalletManagerClient(cfg);
7783

7884
// Ping endpoint handler
79-
router.post('v1.advancedwalletmanager.ping', [
85+
router.post('advancedwallet.mbe.awm.ping', [
8086
responseHandler(async () => {
8187
logger.debug('Pinging advanced wallet manager');
8288

@@ -101,7 +107,7 @@ export function createAdvancedWalletManagerHealthRouter(
101107
}),
102108
]);
103109

104-
router.get('v1.advancedwalletmanager.version', [
110+
router.get('advancedwallet.mbe.awm.version', [
105111
responseHandler(async () => {
106112
try {
107113
// Use the client's getVersion method instead of direct HTTP request

src/masterBitgoExpress/routers/consolidateRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const ConsolidateResponse: HttpResponse = {
4242
* Use this endpoint only with advanced wallets. For other wallet types, use [Consolidate account (simple)](https://developers.bitgo.com/reference/expresswalletconsolidateaccount).
4343
*
4444
* @tag Advanced Wallets
45-
* @operationId advancedwalletconsolidate
45+
* @operationId advancedwallet.consolidate
4646
*/
4747
export const ConsolidateRoute = httpRoute({
4848
method: 'POST',

src/masterBitgoExpress/routers/consolidateUnspentsRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export const ConsolidateUnspentsResponse: HttpResponse = {
8181
* Use this endpoint only with advanced wallets. For other wallet types, use [Consolidate unspents (simple)](https://developers.bitgo.com/reference/expresswalletconsolidateunspents).
8282
*
8383
* @tag Advanced Wallets
84-
* @operationId advancedwalletconsolidateunspents
84+
* @operationId advancedwallet.consolidate.unspents
8585
*/
8686
export const ConsolidateUnspentsRoute = httpRoute({
8787
method: 'POST',

src/masterBitgoExpress/routers/generateWalletRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ const GenerateWalletRequest = {
342342
* 5. Creates the wallet on BitGo with the 3 keys.
343343
*
344344
* @tag Advanced Wallets
345-
* @operationId advancedwalletgenerate
345+
* @operationId advancedwallet.generate
346346
*/
347347
export const WalletGenerateRoute = httpRoute({
348348
method: 'POST',

src/masterBitgoExpress/routers/healthCheck.ts

Lines changed: 35 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,44 @@ const VersionResponse: HttpResponse = {
1616
};
1717

1818
/**
19-
* Ping Check
19+
* Ping (MBE)
20+
*
21+
* Test your connection to the Master Bitgo Express (MBE) server.
2022
*
2123
* @tag Advanced Wallets
22-
* @operationId v1.health.ping
23-
* @private
24+
* @operationId advancedwallet.mbe.ping
2425
*/
26+
const PingRoute = httpRoute({
27+
method: 'POST',
28+
path: '/ping',
29+
request: httpRequest({}),
30+
response: PingResponse,
31+
description: 'Health check endpoint that returns server status',
32+
});
33+
34+
/**
35+
* Check Version (MBE)
36+
*
37+
* Check your version of the Master Bitgo Express (MBE) server.
38+
*
39+
* @tag Advanced Wallets
40+
* @operationId advancedwallet.mbe.version
41+
*/
42+
const VersionRoute = httpRoute({
43+
method: 'GET',
44+
path: '/version',
45+
request: httpRequest({}),
46+
response: VersionResponse,
47+
description: 'Returns the current version of the server',
48+
});
49+
2550
export const HealthCheckApiSpec = apiSpec({
26-
'v1.health.ping': {
27-
post: httpRoute({
28-
method: 'POST',
29-
path: '/ping',
30-
request: httpRequest({}),
31-
response: PingResponse,
32-
description: 'Health check endpoint that returns server status',
33-
}),
51+
'advancedwallet.mbe.ping': {
52+
post: PingRoute,
3453
},
35-
/**
36-
* Version Check
37-
*
38-
* @tag Advanced Wallets
39-
* @operationId v1.health.version
40-
* @private
41-
*/
42-
'v1.health.version': {
43-
get: httpRoute({
44-
method: 'GET',
45-
path: '/version',
46-
request: httpRequest({}),
47-
response: VersionResponse,
48-
description: 'Returns the current version of the server',
49-
}),
54+
55+
'advancedwallet.mbe.version': {
56+
get: VersionRoute,
5057
},
5158
});
5259

@@ -59,7 +66,7 @@ export function createHealthCheckRouter(
5966
});
6067

6168
// Ping endpoint handler
62-
router.post('v1.health.ping', [
69+
router.post('advancedwallet.mbe.ping', [
6370
responseHandler(() =>
6471
Response.ok({
6572
status: `${serverType} server is ok!`,
@@ -69,7 +76,7 @@ export function createHealthCheckRouter(
6976
]);
7077

7178
// Version endpoint handler
72-
router.get('v1.health.version', [
79+
router.get('advancedwallet.mbe.version', [
7380
responseHandler(() =>
7481
Response.ok({
7582
version: pjson.version,

src/masterBitgoExpress/routers/recoveryConsolidationsRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ const RecoveryConsolidationsWalletResponse: HttpResponse = {
122122
* Use this endpoint only with advanced wallets. For other wallet types, use the [Wallet Recovery Wizard](https://developers.bitgo.com/docs/wallets-recover#/).
123123
*
124124
* @tag Advanced Wallets
125-
* @operationId advancedwalletconsolidaterecovery
125+
* @operationId advancedwallet.consolidate.recovery
126126
*/
127127
export const RecoveryConsolidationsRoute = httpRoute({
128128
method: 'POST',

src/masterBitgoExpress/routers/recoveryRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ const RecoveryWalletRequest = {
294294
* Use this endpoint only with advanced wallets. For other wallet types, use the [Wallet Recovery Wizard](https://developers.bitgo.com/docs/wallets-recover#/).
295295
*
296296
* @tag Advanced Wallets
297-
* @operationId advancedwalletrecovery
297+
* @operationId advancedwallet.recovery
298298
*/
299299
export const RecoveryRoute = httpRoute({
300300
method: 'POST',

0 commit comments

Comments
 (0)