chore(mbe): address comments

Ticket: WP-5232

Author: pranavjain97

src/__tests__/api/master/ecdsa.test.ts

@@ -6,7 +6,6 @@ import {
   Wallet,
   TxRequest,
   IRequestTracer,
-  TxRequestVersion,
   Environments,
   RequestTracer,
   EcdsaMPCv2Utils,

src/__tests__/api/master/eddsa.test.ts

@@ -6,7 +6,6 @@ import {
   Wallet,
   TxRequest,
   IRequestTracer,
-  TxRequestVersion,
   Environments,
   RequestTracer,
   EddsaUtils,

src/__tests__/api/master/sendMany.test.ts

@@ -9,7 +9,6 @@ import { Environments, Wallet } from '@bitgo/sdk-core';
 import { Coin } from 'bitgo';
 import assert from 'assert';
 import * as eddsa from '../../../api/master/handlers/eddsa';
-import * as ecdsa from '../../../api/master/handlers/ecdsaMPCv2';
 
 describe('POST /api/:coin/wallet/:walletId/sendmany', () => {
   let agent: request.SuperAgentTest;

src/api/master/clients/enclavedExpressClient.ts

@@ -612,7 +612,7 @@ export class EnclavedExpressClient {
     }
 
     try {
-      let request = this['apiClient']['v1.mpc.sign'].post({
+      let request = this.apiClient['v1.mpc.sign'].post({
         coin: this['coin'],
         shareType: 'mpcv2round1',
         ...params,
@@ -645,7 +645,7 @@ export class EnclavedExpressClient {
     }
 
     try {
-      let request = this['apiClient']['v1.mpc.sign'].post({
+      let request = this.apiClient['v1.mpc.sign'].post({
         coin: this['coin'],
         shareType: 'mpcv2round2',
         ...params,
@@ -678,7 +678,7 @@ export class EnclavedExpressClient {
     }
 
     try {
-      let request = this['apiClient']['v1.mpc.sign'].post({
+      let request = this.apiClient['v1.mpc.sign'].post({
         coin: this['coin'],
         shareType: 'mpcv2round3',
         ...params,

src/api/master/handlers/ecdsaMPCv2.ts

@@ -2,7 +2,6 @@ import {
   BaseCoin,
   BitGoBase,
   EcdsaMPCv2Utils,
-  getTxRequest,
   IRequestTracer,
   RequestType,
   SupplementGenerateWalletOptions,

src/api/master/handlers/handleSendMany.ts

@@ -80,10 +80,9 @@ export async function handleSendMany(req: MasterApiSpecRouteRequest<'v1.wallet.s
     throw new Error(`Wallet ${walletId} not found`);
   }
 
-  // TODO: Re-enable this validation when test wallets are properly configured
-  // if (wallet.type() !== 'cold' || wallet.subType() !== 'onPrem') {
-  //   throw new Error('Wallet is not an on-prem wallet');
-  // }
+  if (wallet.type() !== 'cold' || wallet.subType() !== 'onPrem') {
+    throw new Error('Wallet is not an on-prem wallet');
+  }
 
   const keyIdIndex = params.source === 'user' ? KeyIndices.USER : KeyIndices.BACKUP;
   logger.info(`Key ID index: ${keyIdIndex}`);
@@ -100,11 +99,11 @@ export async function handleSendMany(req: MasterApiSpecRouteRequest<'v1.wallet.s
   if (params.pubkey && signingKeychain.pub !== params.pubkey) {
     throw new Error(`Pub provided does not match the keychain on wallet for ${params.source}`);
   }
-  // if (params.commonKeychain && signingKeychain.commonKeychain !== params.commonKeychain) {
-  //   throw new Error(
-  //     `Common keychain provided does not match the keychain on wallet for ${params.source}`,
-  //   );
-  // }
+  if (params.commonKeychain && signingKeychain.commonKeychain !== params.commonKeychain) {
+    throw new Error(
+      `Common keychain provided does not match the keychain on wallet for ${params.source}`,
+    );
+  }
 
   try {
     // Create TSS send parameters with custom signing functions if needed