Merge pull request #92 from BitGo/WP-5296/remove-console-logs

fix(mbe,ebe): remove console logs

Author: pranavjain97

src/__tests__/api/enclaved/postIndependentKey.test.ts

@@ -65,11 +65,6 @@ describe('postIndependentKey', () => {
 
     const kmsNock = nock(kmsUrl).post(`/key`).reply(200, mockKmsResponse);
 
-    console.log(cfg.kmsUrl);
-
-    console.warn(nock.activeMocks());
-    console.warn(nock.isActive());
-
     const response = await agent
       .post(`/api/${coin}/key/independent`)
       .set('Authorization', `Bearer ${accessToken}`)

src/__tests__/api/enclaved/recoveryMusigEth.test.ts

@@ -86,9 +86,6 @@ describe('recoveryMultisigTransaction', () => {
       .query({ source: 'backup', useLocalEncipherment: false })
       .reply(200, mockKmsBackupResponse);
 
-    console.warn(nock.activeMocks());
-    console.warn(nock.isActive());
-
     const response = await agent
       .post(`/api/${coin}/multisig/recovery`)
       .set('Authorization', `Bearer ${accessToken}`)

src/__tests__/api/master/musigRecovery.test.ts

@@ -65,10 +65,7 @@ describe('POST /api/:coin/wallet/recovery', () => {
 
     // the call to our own master api express endpoint
     const response = await agent
-      .post(`/api/${coin}/wallet/recovery`, (body) => {
-        console.log('Nock received body:', body);
-        return true;
-      })
+      .post(`/api/${coin}/wallet/recovery`)
       .set('Authorization', `Bearer ${accessToken}`)
       .send({
         multiSigRecoveryParams: {

src/api/enclaved/handlers/ecdsaMPCv2Round.ts

@@ -6,6 +6,7 @@ import {
 } from '../../../enclavedBitgoExpress/routers/enclavedApiSpec';
 import { MPCv2PartiesEnum } from '@bitgo-beta/sdk-core/dist/src/bitgo/utils/tss/ecdsa';
 import { KmsClient } from '../../../kms/kmsClient';
+import logger from '../../../logger';
 
 export async function ecdsaMPCv2Round(
   req: EnclavedApiSpecRouteRequest<'v1.mpcv2.round', 'post'>,
@@ -115,7 +116,6 @@ export async function ecdsaMPCv2Round(
     try {
       outgoingMessages = session.handleIncomingMessages(deserializedIncomingMessages);
     } catch (error: any) {
-      console.error('Error handling incoming messages:', error);
       throw new Error(`Failed to handle incoming messages: ${error.message}`);
     }
   }
@@ -147,7 +147,7 @@ export async function ecdsaMPCv2Round(
       password: plaintextKey,
     });
   } catch (error) {
-    console.error('Encryption error details:', error);
+    logger.error('Encryption error details:', error);
     throw error;
   }
 

src/api/enclaved/mpcInitialize.ts

@@ -112,7 +112,6 @@ export async function eddsaInitialize(
     };
   } catch (error) {
     debugLogger('Failed to initialize mpc key generation', error);
-    console.error('Encryption error details:', error);
     throw error;
   }
 }

src/kms/kmsClient.ts

@@ -40,7 +40,7 @@ export class KmsClient {
     try {
       kmsResponse = await superagent.post(`${this.url}/key`).set('x-api-key', 'abc').send(params);
     } catch (error: any) {
-      console.log('Error posting key to KMS', error);
+      debugLogger('Error posting key to KMS', error);
       throw error;
     }
 
@@ -68,7 +68,7 @@ export class KmsClient {
         useLocalEncipherment: params.options?.useLocalEncipherment ?? false,
       });
     } catch (error: any) {
-      console.log('Error getting key from KMS', error);
+      debugLogger('Error getting key from KMS', error);
       throw error;
     }