perf: remove unneeded nullish check

ericcrosson-bitgo · ericcrosson-bitgo · commit 08412d587012 · 2024-04-23T11:17:06.000-05:00
In the current implementation, `description` is always a string, so there is no point checking if it is not undefined. This closes https://github.com/BitGo/api-ts/security/code-scanning/4
diff --git a/packages/openapi-generator/src/jsdoc.ts b/packages/openapi-generator/src/jsdoc.ts
@@ -27,9 +27,7 @@ export function parseCommentBlock(comment: Block): JSDoc {
     }
   }
 
-  if (description !== undefined) {
-    description = description.trim();
-  }
+  description = description.trim();
 
   return {
     ...(summary.length > 0 ? { summary } : {}),

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,7 @@ export function parseCommentBlock(comment: Block): JSDoc {`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
`30`		`- if (description !== undefined) {`
`31`		`- description = description.trim();`
`32`		`- }`
	`30`	`+ description = description.trim();`
`33`	`31`
`34`	`32`	`return {`
`35`	`33`	`...(summary.length > 0 ? { summary } : {}),`