Merge pull request #817 from BitGo/merge-bug

ad-world · web-flow · commit 1e6f5cf78a80 · 2024-07-02T18:28:17.000-04:00
fix: fix merging unions of undefined schemas
diff --git a/packages/openapi-generator/src/optimize.ts b/packages/openapi-generator/src/optimize.ts
@@ -68,7 +68,9 @@ function mergeUnions(schema: Schema): Schema {
 
   return {
     type: 'union',
-    schemas: Array.from(resultingSchemas).map((s) => JSON.parse(s)),
+    schemas: Array.from(resultingSchemas)
+      .filter((s) => s != undefined)
+      .map((s) => JSON.parse(s)),
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,9 @@ function mergeUnions(schema: Schema): Schema {`
`68`	`68`
`69`	`69`	`return {`
`70`	`70`	`type: 'union',`
`71`		`- schemas: Array.from(resultingSchemas).map((s) => JSON.parse(s)),`
	`71`	`+ schemas: Array.from(resultingSchemas)`
	`72`	`+ .filter((s) => s != undefined)`
	`73`	`+ .map((s) => JSON.parse(s)),`
`72`	`74`	`};`
`73`	`75`	`}`
`74`	`76`