Merge pull request #762 from BitGo/VL-1836-fix-error-message

Don't silently drop properties when processing an `httpRoute`

Author: ericcrosson-bitgo

packages/openapi-generator/src/knownImports.ts

@@ -206,13 +206,14 @@ export const KNOWN_IMPORTS: KnownImports = {
       if (schema.type !== 'object') {
         return E.left('httpRoute parameter must be object');
       }
-      const props = Object.entries(schema.properties).reduce((acc, [key, prop]) => {
-        const derefedE = deref(prop);
+      const props: Record<string, Schema> = {};
+      for (const [key, value] of Object.entries(schema.properties)) {
+        const derefedE = deref(value);
         if (E.isLeft(derefedE)) {
-          return acc;
+          return derefedE;
         }
-        return { ...acc, [key]: derefedE.right };
-      }, {});
+        props[key] = derefedE.right;
+      }
       return E.right({
         type: 'object',
         properties: props,

packages/openapi-generator/test/apiSpec.test.ts

@@ -265,3 +265,28 @@ test('api spec comment parser', async () => {
 
   assert(commentParsed);
 });
+
+const MISSING_REFERENCE = {
+  '/index.ts': `
+    import * as t from 'io-ts';
+    import * as h from '@api-ts/io-ts-http';
+
+    import { Foo } from 'foo';
+
+    export const test = h.apiSpec({
+      'api.test': {
+        get: h.httpRoute({
+          path: '/test',
+          method: 'GET',
+          request: Foo,
+          response: {
+            200: t.string,
+          },
+        })
+      }
+    });`,
+};
+
+testCase('missing reference', MISSING_REFERENCE, '/index.ts', {}, [
+  "Cannot find 'Foo' from 'foo'",
+]);