Merge pull request #41 from BitGo/utxo_psbt2

fix(psbt): pass value to hashForSignature for fork support

Author: brandonblack

src/psbt.js

@@ -1022,6 +1022,7 @@ function getHashForSig(inputIndex, input, cache, forValidate, sighashTypes) {
       inputIndex,
       meaningfulScript,
       sighashType,
+      prevout.value,
     );
   }
   return {

src/transaction.d.ts

@@ -44,7 +44,7 @@ export declare class Transaction<TNumber extends number | bigint = number> {
      * hashType, and then hashes the result.
      * This hash can then be used to sign the provided transaction input.
      */
-    hashForSignature(inIndex: number, prevOutScript: Buffer, hashType: number): Buffer;
+    hashForSignature(inIndex: number, prevOutScript: Buffer, hashType: number, prevOutValue?: TNumber): Buffer;
     hashForWitnessV1(inIndex: number, prevOutScripts: Buffer[], values: TNumber[], hashType: number, leafHash?: Buffer, annex?: Buffer): Buffer;
     hashForWitnessV0(inIndex: number, prevOutScript: Buffer, value: TNumber, hashType: number): Buffer;
     getHash(forWitness?: boolean): Buffer;

src/transaction.js

@@ -204,7 +204,13 @@ class Transaction {
    * hashType, and then hashes the result.
    * This hash can then be used to sign the provided transaction input.
    */
-  hashForSignature(inIndex, prevOutScript, hashType) {
+  hashForSignature(
+    inIndex,
+    prevOutScript,
+    hashType,
+    // @ts-expect-error Optional for override in forks
+    prevOutValue,
+  ) {
     typeforce(
       types.tuple(types.UInt32, types.Buffer, /* types.UInt8 */ types.Number),
       arguments,

ts_src/psbt.ts

@@ -1348,6 +1348,7 @@ function getHashForSig(
       inputIndex,
       meaningfulScript,
       sighashType,
+      prevout.value,
     );
   }
 

ts_src/transaction.ts

@@ -285,6 +285,8 @@ export class Transaction<TNumber extends number | bigint = number> {
     inIndex: number,
     prevOutScript: Buffer,
     hashType: number,
+    // @ts-expect-error Optional for override in forks
+    prevOutValue?: TNumber,
   ): Buffer {
     typeforce(
       types.tuple(types.UInt32, types.Buffer, /* types.UInt8 */ types.Number),