Skip to content

Commit 3c908f6

Browse files
committed
Enable support for node 12 and disable for node 6
Added the following changes: 1. Obsolete build/test support for Node 6 (BG-19294). 2. Add build/test support for Node 12 (BG-19213). 3. Disable eslint temporarily and move into another PR per Tyler's request (BG-19296). JIRA: BG-19294,BG-19213
1 parent 5779646 commit 3c908f6

File tree

2 files changed

+30
-21
lines changed

2 files changed

+30
-21
lines changed

.drone.jsonnet

Lines changed: 29 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -75,22 +75,23 @@ local step(
7575
"npm install",
7676
],
7777
),
78-
step(
79-
name = "lint",
80-
image = "node:10",
81-
commands = [
82-
"npm run lint",
83-
],
84-
),
78+
/// step(
79+
/// name = "lint",
80+
/// image = "node:10",
81+
/// failure = true,
82+
/// commands = [
83+
/// "npm run lint",
84+
/// ],
85+
/// ),
8586
],
8687
),
8788
pipeline(
8889
kind = "pipeline",
89-
name = "unit tests (node:6)",
90+
name = "unit tests (node:10)",
9091
steps = [
9192
step(
9293
name = "build information",
93-
image = "node:6",
94+
image = "node:10",
9495
commands = [
9596
"node --version",
9697
"npm --version",
@@ -99,14 +100,14 @@ local step(
99100
),
100101
step(
101102
name = "install",
102-
image = "node:6",
103+
image = "node:10",
103104
commands = [
104105
"npm install",
105106
],
106107
),
107108
step(
108109
name = "unit-test",
109-
image = "node:6",
110+
image = "node:10",
110111
depends_on = [
111112
"install",
112113
],
@@ -117,6 +118,14 @@ local step(
117118
MONGO_URI: "mongodb://mongo:27017/key-recovery-service-test",
118119
},
119120
),
121+
step(
122+
name = "audit",
123+
image = "node:10",
124+
/// failure = true,
125+
commands = [
126+
"npm run audit",
127+
],
128+
),
120129
],
121130
trigger = {
122131
branch: {
@@ -130,15 +139,15 @@ local step(
130139
name: "mongo",
131140
image: "mongo:3.4",
132141
},
133-
]
142+
],
134143
),
135144
pipeline(
136145
kind = "pipeline",
137-
name = "unit tests (node:10)",
146+
name = "unit tests (node:12)",
138147
steps = [
139148
step(
140149
name = "build information",
141-
image = "node:10",
150+
image = "node:12",
142151
commands = [
143152
"node --version",
144153
"npm --version",
@@ -147,14 +156,14 @@ local step(
147156
),
148157
step(
149158
name = "install",
150-
image = "node:10",
159+
image = "node:12",
151160
commands = [
152161
"npm install",
153162
],
154163
),
155164
step(
156165
name = "unit-test",
157-
image = "node:10",
166+
image = "node:12",
158167
depends_on = [
159168
"install",
160169
],
@@ -167,10 +176,10 @@ local step(
167176
),
168177
step(
169178
name = "audit",
170-
image = "node:10",
171-
failure = true,
179+
image = "node:12",
180+
/// failure = true,
172181
commands = [
173-
"npm audit",
182+
"npm run audit",
174183
],
175184
),
176185
],
@@ -186,6 +195,6 @@ local step(
186195
name: "mongo",
187196
image: "mongo:3.4",
188197
},
189-
]
198+
],
190199
),
191200
]

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
},
1717
"rules": {
1818
"operator-linebreak": ["error", "before"],
19-
"max-len": ["error", { "code": 120 } ],
19+
"max-len": ["error", { "code": 256 } ],
2020
"indent": ["error", 2, {"SwitchCase": 1, "MemberExpression": "off"}],
2121
"linebreak-style": ["error", "unix"],
2222
"semi": ["error", "always"],

0 commit comments

Comments
 (0)