-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
1code-challengeThis issue has been groomed and is ready to be picked up by a code challenge participant.This issue has been groomed and is ready to be picked up by a code challenge participant.
Description
Overview
If you look at sign.js
, it defines a configuration constants for each coin that the library supports.
These constants are already defined in the upstream library, BitGoJs
; there is no need to create two sources of the truth.
The task: Update this library to leverage the existing constants in BitGoJS.statics
.
Definition of Done
- Refactor all coins to fetch their constants from
BitGoJS.statics
. - All tests should still pass after these changes.
Extra Credit
Are there any other constants in this library that have already been defined in BitGoJS.statics
? If so, please add or create a new issue to track it -- if not, do you see any constants that might be useful to move upstream?
Metadata
Metadata
Assignees
Labels
1code-challengeThis issue has been groomed and is ready to be picked up by a code challenge participant.This issue has been groomed and is ready to be picked up by a code challenge participant.