Skip to content

Commit 4a7ddad

Browse files
committed
[VEX-54]: Warning Diag no longer shown when no warnings present
1 parent 3424e09 commit 4a7ddad

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/updaterLib/core.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,11 @@ def checkNewVersion(softwareName):
178178

179179
if r["prerelease"]: warnings.append("- This release is a pre-release")
180180

181-
warningDiagInstance = warningDiag.WarningDiag(root, "Warnings", warnings)
182-
if warningDiagInstance.response == "no":
183-
ignoreVersion(latestVersionString, softwareName, legacyMode)
184-
break
181+
if len(warnings) != 0:
182+
warningDiagInstance = warningDiag.WarningDiag(root, "Warnings", warnings)
183+
if warningDiagInstance.response == "no":
184+
ignoreVersion(latestVersionString, softwareName, legacyMode)
185+
break
185186

186187
downloadNewVersion(latestVersionString, softwareName, legacyMode, r["tag_name"])
187188
changelogDiag.ChangelogDiag(root, "Changelog", changelog)

0 commit comments

Comments
 (0)