Accept, Reject Offer and Mint on Accept (#528)

Author: zupzup

CHANGELOG.md

@@ -5,6 +5,7 @@
     * Added timestamps for status
     * Call mint endpoint for cancelling
     * Use mint nostr relays from network and fall back to identity ones
+    * Add endpoints to accept, or reject an offer from a mint
 
 # 0.3.13
 

crates/bcr-ebill-api/src/external/mint.rs

@@ -149,7 +149,6 @@ impl MintClientApi for MintClient {
         Ok(reply.into())
     }
 
-    #[allow(dead_code)]
     async fn resolve_quote_for_mint(
         &self,
         mint_url: &str,

crates/bcr-ebill-api/src/service/bill_service/error.rs

@@ -66,6 +66,18 @@ pub enum Error {
     #[error("Mint request can only be cancelled if it's pending.")]
     CancelMintRequestNotPending,
 
+    /// errors that stem from trying to reject a mint request that's not offered
+    #[error("Mint request can only be rejected if it's offered.")]
+    RejectMintRequestNotOffered,
+
+    /// errors that stem from trying to accept a mint request that's not offered
+    #[error("Mint request can only be accepted if it's offered.")]
+    AcceptMintRequestNotOffered,
+
+    /// errors that stem from trying to accept a mint request that's expired
+    #[error("Mint request can only be accepted if it's not expired.")]
+    AcceptMintOfferExpired,
+
     /// errors that stem from bill validation errors
     #[error("bill validation error {0}")]
     Validation(#[from] bcr_ebill_core::ValidationError),

crates/bcr-ebill-api/src/service/bill_service/mod.rs

@@ -110,16 +110,6 @@ pub trait BillServiceApi: ServiceTraitBounds {
         timestamp: u64,
     ) -> Result<BillBlockchain>;
 
-    /// request to mint a bill
-    async fn request_to_mint(
-        &self,
-        bill_id: &str,
-        mint_node_id: &str,
-        signer_public_data: &BillParticipant,
-        signer_keys: &BcrKeys,
-        timestamp: u64,
-    ) -> Result<()>;
-
     /// Check payment status of bills that are requested to pay and not expired and not paid yet, updating their
     /// paid status if they were paid
     async fn check_bills_payment(&self) -> Result<()>;
@@ -180,6 +170,19 @@ pub trait BillServiceApi: ServiceTraitBounds {
         current_identity_node_id: &str,
     ) -> Result<Vec<Endorsement>>;
 
+    /// Clear the bill cache
+    async fn clear_bill_cache(&self) -> Result<()>;
+
+    /// request to mint a bill
+    async fn request_to_mint(
+        &self,
+        bill_id: &str,
+        mint_node_id: &str,
+        signer_public_data: &BillParticipant,
+        signer_keys: &BcrKeys,
+        timestamp: u64,
+    ) -> Result<()>;
+
     /// Returns the mint state for a given bill
     async fn get_mint_state(
         &self,
@@ -194,14 +197,27 @@ pub trait BillServiceApi: ServiceTraitBounds {
         current_identity_node_id: &str,
     ) -> Result<()>;
 
+    /// Accept a mint offer for a given request to mint
+    async fn accept_mint_offer(
+        &self,
+        mint_request_id: &str,
+        signer_public_data: &BillParticipant,
+        signer_keys: &BcrKeys,
+        timestamp: u64,
+    ) -> Result<()>;
+
+    /// Reject a mint offer for a given request to mint
+    async fn reject_mint_offer(
+        &self,
+        mint_request_id: &str,
+        current_identity_node_id: &str,
+    ) -> Result<()>;
+
     /// Check mint state for a given bill
     async fn check_mint_state(&self, bill_id: &str, current_identity_node_id: &str) -> Result<()>;
 
     /// Check mint state for all bills
     async fn check_mint_state_for_all_bills(&self) -> Result<()>;
-
-    /// Clear the bill cache
-    async fn clear_bill_cache(&self) -> Result<()>;
 }
 
 #[cfg(test)]