set network to identity and check for network version on startup (#545)

Author: zupzup

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.3.16
+
+* Set the BTC network in the identity and check, if the persisted network is the same as the one configured in the application, failing if it doesn't.
+
 # 0.3.15
 
 * Upload and download files to and from Nostr using Blossom

Cargo.toml

@@ -1,5 +1,5 @@
 [workspace.package]
-version = "0.3.15"
+version = "0.3.16"
 edition = "2024"
 license = "MIT"
 

crates/bcr-ebill-api/src/tests/mod.rs

@@ -244,6 +244,7 @@ pub mod tests {
             async fn get_seedphrase(&self) -> Result<String>;
             async fn get_current_identity(&self) -> Result<ActiveIdentityState>;
             async fn set_current_identity(&self, identity_state: &ActiveIdentityState) -> Result<()>;
+            async fn set_or_check_network(&self, configured_network: bitcoin::Network) -> Result<()>;
         }
     }
 

crates/bcr-ebill-persistence/Cargo.toml

@@ -21,6 +21,7 @@ nostr.workspace = true
 bcr-ebill-core = { path = "../bcr-ebill-core" }
 tokio.workspace = true
 tokio_with_wasm.workspace = true
+bitcoin.workspace = true
 arc-swap = "1.7"
 
 # Enable "kv-indxdb" only for WebAssembly (wasm32)

crates/bcr-ebill-persistence/src/db/identity.rs

@@ -16,6 +16,7 @@ impl SurrealIdentityStore {
     const IDENTITY_TABLE: &'static str = "identity";
     const ACTIVE_IDENTITY_TABLE: &'static str = "active_identity";
     const KEY_TABLE: &'static str = "identity_key";
+    const NETWORK_TABLE: &'static str = "identity_network";
     const UNIQUE_ID: &'static str = "unique_record";
 
     pub fn new(db: SurrealWrapper) -> Self {
@@ -29,6 +30,14 @@ impl SurrealIdentityStore {
             .select_one(Self::KEY_TABLE, Self::UNIQUE_ID.to_owned())
             .await
     }
+
+    async fn get_db_network(&self) -> Result<Option<bitcoin::Network>> {
+        let result: Option<NetworkDb> = self
+            .db
+            .select_one(Self::NETWORK_TABLE, Self::UNIQUE_ID.to_owned())
+            .await?;
+        Ok(result.map(|nw| nw.network))
+    }
 }
 
 impl ServiceTraitBounds for SurrealIdentityStore {}
@@ -84,6 +93,31 @@ impl IdentityStoreApi for SurrealIdentityStore {
         }
     }
 
+    async fn set_or_check_network(&self, configured_network: bitcoin::Network) -> Result<()> {
+        let network = self.get_db_network().await?;
+        match network {
+            None => {
+                let _: Option<NetworkDb> = self
+                    .db
+                    .create(
+                        Self::NETWORK_TABLE,
+                        Some(Self::UNIQUE_ID.to_owned()),
+                        NetworkDb {
+                            network: configured_network,
+                        },
+                    )
+                    .await?;
+                Ok(())
+            }
+            Some(nw) => {
+                if configured_network != nw {
+                    return Err(Error::NetworkDoesNotMatch);
+                }
+                Ok(())
+            }
+        }
+    }
+
     async fn get_or_create_key_pair(&self) -> Result<BcrKeys> {
         let keys = match self.get_key_pair().await {
             Ok(keys) => keys,
@@ -134,6 +168,12 @@ impl IdentityStoreApi for SurrealIdentityStore {
         Ok(())
     }
 }
+
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct NetworkDb {
+    pub network: bitcoin::Network,
+}
+
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct ActiveIdentityDb {
     pub personal: String,

crates/bcr-ebill-persistence/src/identity.rs

@@ -32,6 +32,8 @@ pub trait IdentityStoreApi: ServiceTraitBounds {
     async fn get_current_identity(&self) -> Result<ActiveIdentityState>;
     /// Sets the given current active identity state
     async fn set_current_identity(&self, identity_state: &ActiveIdentityState) -> Result<()>;
+    /// Sets the network for this identity, or, if it's set, checks if the set network is the same as the configured one
+    async fn set_or_check_network(&self, configured_network: bitcoin::Network) -> Result<()>;
 }
 
 #[cfg_attr(target_arch = "wasm32", async_trait(?Send))]

crates/bcr-ebill-persistence/src/lib.rs

@@ -82,6 +82,9 @@ pub enum Error {
     #[error("no identity key found")]
     NoIdentityKey,
 
+    #[error("Network does not match")]
+    NetworkDoesNotMatch,
+
     #[allow(dead_code)]
     #[error("Failed to convert integer {0}")]
     FromInt(#[from] std::num::TryFromIntError),

crates/bcr-ebill-wasm/src/lib.rs

@@ -87,6 +87,10 @@ pub async fn initialize_api(
 
     // init db
     let db = get_db_context(&api_config).await?;
+    // set the network and check if the configured network matches the persisted network and fail, if not
+    db.identity_store
+        .set_or_check_network(api_config.bitcoin_network())
+        .await?;
     let keys = db.identity_store.get_or_create_key_pair().await?;
 
     info!("Initialized WASM API {}", VERSION);