Adapt Company Identity Proof, Adapt Signatories, Add Change Signatory (#747)

Email

Author: zupzup

CHANGELOG.md

@@ -23,6 +23,8 @@
     * Add endpoints to `confirm`, `verify` an email address and to `get_email_confirmations`
     * Adapt `IdentityProof` Block to include the email confirmation signed by the mint
     * Split up `update_identity` and `update_email` for identity and create identity proof block on email update
+    * Change flow for company creation to first call `create_company_keys` to get a key pair and node id, then confirm email of creator, then create company
+        * Add `email` to signatory and use a data structure for signatories (breaking API and DB change)
 
 # 0.4.12
 

crates/bcr-ebill-api/src/service/bill_service/issue.rs

@@ -188,7 +188,6 @@ impl BillService {
             }
         }
 
-        // TODO: replace with directly creating BillIssueBlockData
         let bill = BitcreditBill {
             id: bill_id.clone(),
             country_of_issuing: data.country_of_issuing,

crates/bcr-ebill-api/src/service/bill_service/payment.rs

@@ -220,7 +220,7 @@ impl BillService {
                             .0
                             .signatories
                             .iter()
-                            .any(|s| s == &identity.identity.node_id)
+                            .any(|s| s.node_id == identity.identity.node_id)
                     {
                         let reason = match payment_info.reason {
                             BillRecourseReasonBlockData::Pay => {
@@ -354,7 +354,7 @@ impl BillService {
                             .0
                             .signatories
                             .iter()
-                            .any(|s| s == &identity.identity.node_id)
+                            .any(|s| s.node_id == identity.identity.node_id)
                     {
                         let _ = self
                                 .execute_bill_action(