don't hide get-file errors (#472)

Author: zupzup

CHANGELOG.md

@@ -1,6 +1,7 @@
 # 0.3.5
 
 * Add in-depth tests for bill validation
+* Properly propagate and log errors when getting a file (e.g. an avatar)
 
 # 0.3.4
 

crates/bcr-ebill-wasm/src/api/bill.rs

@@ -104,8 +104,7 @@ impl Bill {
         let file_bytes = get_ctx()
             .bill_service
             .open_and_decrypt_attached_file(bill_id, file_name, &keys.private_key)
-            .await
-            .map_err(|_| Error::NotFound)?;
+            .await?;
 
         let content_type = detect_content_type_for_bytes(&file_bytes)
             .ok_or(Error::Validation(ValidationError::InvalidContentType))?;

crates/bcr-ebill-wasm/src/api/company.rs

@@ -45,8 +45,7 @@ impl Company {
         let file_bytes = get_ctx()
             .company_service
             .open_and_decrypt_file(id, file_name, &private_key)
-            .await
-            .map_err(|_| Error::NotFound)?;
+            .await?;
         get_ctx().contact_service.get_contact(id).await?; // check if contact exists
 
         let content_type = detect_content_type_for_bytes(&file_bytes)

crates/bcr-ebill-wasm/src/api/contact.rs

@@ -34,8 +34,7 @@ impl Contact {
         let file_bytes = get_ctx()
             .contact_service
             .open_and_decrypt_file(id, file_name, &private_key)
-            .await
-            .map_err(|_| service::Error::NotFound)?;
+            .await?;
 
         let content_type = detect_content_type_for_bytes(&file_bytes).ok_or(
             service::Error::Validation(ValidationError::InvalidContentType),

crates/bcr-ebill-wasm/src/api/identity.rs

@@ -50,8 +50,7 @@ impl Identity {
         let file_bytes = get_ctx()
             .identity_service
             .open_and_decrypt_file(&id, file_name, &private_key)
-            .await
-            .map_err(|_| Error::NotFound)?;
+            .await?;
 
         let content_type = detect_content_type_for_bytes(&file_bytes)
             .ok_or(Error::Validation(ValidationError::InvalidContentType))?;