Skip to content

Conversation

@cleot
Copy link
Contributor

@cleot cleot commented Jun 18, 2025

User description

fix: matrix has no access to secrets


PR Type

Bug fix


Description

• Fix GitHub Actions workflow matrix configuration
• Replace secrets with vars for Cloudflare project names


Changes walkthrough 📝

Relevant files
Bug fix
deploy-wildcat-docker.yml
Replace secrets with vars in workflow matrix                         

.github/workflows/deploy-wildcat-docker.yml

• Changed secrets.CLOUDFLARE_PROJECT_DEV_DOCKER to
vars.CLOUDFLARE_PROJECT_DEV_DOCKER
• Changed
secrets.CLOUDFLARE_PROJECT_DOCKER to vars.CLOUDFLARE_PROJECT_DOCKER

Fixed matrix configuration to use proper variable access

+2/-2     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change

    Verify that the Cloudflare project names have been properly migrated from repository secrets to repository variables and that the values are correctly set in the GitHub repository settings.

      project_name: ${{ vars.CLOUDFLARE_PROJECT_DEV_DOCKER }}
      vite_api_base_url: ${{ vars.VITE_API_BASE_URL_DEV_DOCKER }}
      vite_keycloak_url: ${{ vars.VITE_KEYCLOAK_URL_DEV_DOCKER }}
      vite_keycloak_realm: 'dev'
      vite_keycloak_client_id: 'bff-dashboard'
    - environment: 'wildcat-docker'
      project_name: ${{ vars.CLOUDFLARE_PROJECT_DOCKER }}

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cleot cleot merged commit 88db7eb into master Jun 18, 2025
    5 checks passed
    @codecov
    Copy link

    codecov bot commented Jun 18, 2025

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    📢 Thoughts on this report? Let us know!

    @cleot cleot deleted the cleot/fix-workflow-error branch June 18, 2025 18:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants