fix the enable Minting button
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingpeanut157
requested review from
JulianVIE,
Copilot,
cryptosalomao,
mtbitcr and
zupzup
Deploying wildcat-dashboard with
|
| Latest commit: |
edd936c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acd73319.wildcat-dashboard.pages.dev |
| Branch Preview URL: | https://peanut-minting-2.wildcat-dashboard.pages.dev |
Copilot finished reviewing on behalf of
codingpeanut157
November 21, 2025 15:41
There was a problem hiding this comment.
Pull request overview
This PR fixes the "Enable Minting" button that was incorrectly disabled. The fix introduces a new minting_status field in the InfoReply type to properly track whether minting is enabled or disabled, replacing the previous logic that inferred minting status from keyset data.
Key changes:
- Added
MintingStatustype andminting_statusfield to the "Accepted" variant ofInfoReply - Renamed
newKeysetprop tomintingEnabledin theQuoteActionscomponent for clarity - Updated button disabled logic to use the new
minting_statusfield directly from the API response
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/generated/client/types.gen.ts |
Added MintingStatus type definition and minting_status field to InfoReply type for "Accepted" status variant |
src/pages/quotes/QuotePage.tsx |
Renamed prop from newKeyset to mintingEnabled, updated button logic to use new API field, removed obsolete badge display, and simplified "Request to Pay" button conditional |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
codingpeanut157
force-pushed
the
peanut/minting_2
branch
2 times, most recently
from
61e3f59 to
32b124b
Compare
zupzup
reviewed
Nov 21, 2025
src/pages/quotes/QuotePage.tsx
Outdated
| variant={newKeyset ? "default" : "destructive"} | ||
| className={newKeyset ? "bg-red-500" : "bg-blue-500"} | ||
| variant={mintingEnabled ? "default" : "destructive"} | ||
| className={minting ? "bg-red-500" : "bg-blue-500"} |
zupzup
approved these changes
Nov 21, 2025
| className={minting ? "bg-red-500" : "bg-blue-500"} | ||
| > | ||
| {newKeyset ? "Disabled" : "Enabled"} | ||
| {mintingEnabled ? "Disabled" : "Enabled"} |
There was a problem hiding this comment.
So this button is disabled when minting is enabled? 🤔
Contributor
Author
There was a problem hiding this comment.
yes
when minting has been enabled already, the button to enable it should be disabled
😅
it was mistakenly greied out all the times, now we have a new field in InfoReply that informs us on the status of the minting.
codingpeanut157
force-pushed
the
peanut/minting_2
branch
from
32b124b to
edd936c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cryptosalomao
approved these changes
Nov 24, 2025
JulianVIE
approved these changes
Nov 24, 2025
mtbitcr
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
it was mistakenly greied out all the times, now we have a new field in InfoReply that informs us on the status of the minting.