orphanage: avoid vtx iteration when no orphans

furszy · janus · commit f883e5fa9e58 · 2025-09-13T03:09:35.000+01:00
diff --git a/src/node/txorphanage.cpp b/src/node/txorphanage.cpp
@@ -832,6 +832,8 @@ bool TxOrphanageImpl::HaveTxToReconsider(NodeId peer)
 }
 void TxOrphanageImpl::EraseForBlock(const CBlock& block)
 {
+    if (m_orphans.empty()) return;
+
     std::set<Wtxid> wtxids_to_erase;
     for (const CTransactionRef& ptx : block.vtx) {
         const CTransaction& block_tx = *ptx;

Original file line number	Diff line number	Diff line change
`@@ -832,6 +832,8 @@ bool TxOrphanageImpl::HaveTxToReconsider(NodeId peer)`
`832`	`832`	`}`
`833`	`833`	`void TxOrphanageImpl::EraseForBlock(const CBlock& block)`
`834`	`834`	`{`
	`835`	`+ if (m_orphans.empty()) return;`
	`836`	`+`
`835`	`837`	`std::set<Wtxid> wtxids_to_erase;`
`836`	`838`	`for (const CTransactionRef& ptx : block.vtx) {`
`837`	`839`	`const CTransaction& block_tx = *ptx;`