decided to use backoff system, lower the default limit

Author: Bitl

src/game/client/tf/tf_gc_client.cpp

@@ -308,15 +308,19 @@ void CTFGCClientSystem::InvalidatePingData()
 // Backoff api
 void CTFGCClientSystem::WebapiInventoryState_t::Backoff()
 {
+	if (m_nBackoffSec == 0)
 #ifdef BDSBASE
-	RequestSucceeded();
+		m_nBackoffSec = GC_BACKOFF_RATELIMIT_TIME;
 #else
-	if ( m_nBackoffSec == 0 )
 		m_nBackoffSec = 20;
+#endif
 	else
 		m_nBackoffSec = (m_nBackoffSec * 12 + 9) / 10; // exponential backoff @ 1.2x factor, round up
 
 	m_rtNextRequest = CRTime::RTime32TimeCur() + m_nBackoffSec;
+
+#ifdef BDSBASE
+	DevMsg("[GC CLIENT] Backing off for an additional %i seconds.\n", m_nBackoffSec);
 #endif
 }
 
@@ -328,11 +332,7 @@ void CTFGCClientSystem::WebapiInventoryState_t::RequestSucceeded()
 
 bool CTFGCClientSystem::WebapiInventoryState_t::IsBackingOff()
 {
-#ifdef BDSBASE
-	return false;
-#else
 	return m_rtNextRequest != 0 && CRTime::RTime32TimeCur() <= m_rtNextRequest;
-#endif
 }
 
 void CTFGCClientSystem::WebapiInventoryThink()

src/game/server/tf/tf_gc_server.cpp

@@ -4029,15 +4029,19 @@ ConVar tf_mm_trusted( "tf_mm_trusted", "0", FCVAR_NOTIFY | FCVAR_HIDDEN,
 // Backoff api
 void CTFGCServerSystem::WebapiEquipmentState_t::Backoff()
 {
+	if ( m_nBackoffSec == 0 )
 #ifdef BDSBASE
-	RequestSucceeded();
+		m_nBackoffSec = GC_BACKOFF_RATELIMIT_TIME;
 #else
-	if ( m_nBackoffSec == 0 )
 		m_nBackoffSec = 20;
+#endif
 	else
 		m_nBackoffSec = ( m_nBackoffSec * 12 + 9 ) / 10; // exponential backoff @ 1.2x factor, round up
 
 	m_rtNextRequest = CRTime::RTime32TimeCur() + m_nBackoffSec;
+
+#ifdef BDSBASE
+	DevMsg("[GC SERVER] Backing off for an additional %i seconds.\n", m_nBackoffSec);
 #endif
 }
 
@@ -4049,11 +4053,7 @@ void CTFGCServerSystem::WebapiEquipmentState_t::RequestSucceeded()
 
 bool CTFGCServerSystem::WebapiEquipmentState_t::IsBackingOff()
 {
-#ifdef BDSBASE
-	return false;
-#else
 	return m_rtNextRequest != 0 && CRTime::RTime32TimeCur() <= m_rtNextRequest;
-#endif
 }
 
 CTFGCServerSystem::WebapiEquipmentState_t& CTFGCServerSystem::FindOrCreateWebapiEquipmentState( CSteamID steamID )

src/game/shared/tf/tf_gc_shared.h

@@ -18,6 +18,13 @@ class IJobReliableMessage; // Defined below
 
 #define MMLog(...) do { ::Msg( __VA_ARGS__ ); } while(false)
 
+#ifdef BDSBASE
+// the backoff system is a good idea, but the inventory delay is way too high (20 seconds by default).
+// as a result, we have lowered it to 5 seconds.
+#define GC_BACKOFF_RATELIMIT_TIME 5
+//#define GC_BACKOFF_RATELIMIT_TIME 20
+#endif
+
 // Timeout upon successfully sending a reliable message before deciding we should try again.  This affects how quickly
 // we can detect the Stalled state for a queue in the case of non-responses, as well.
 #ifdef CLIENT_DLL