Skip to content

Commit 27c0ac4

Browse files
committed
Updating code comments to reflect changes in listening for connections when using SOCKS.
1 parent 97f0c56 commit 27c0ac4

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/class_singleListener.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,10 @@ def setup(self, selfInitiatedConnections):
2121
self.selfInitiatedConnections = selfInitiatedConnections
2222

2323
def run(self):
24-
# We don't want to accept incoming connections if the user is using a
25-
# SOCKS proxy. If they eventually select proxy 'none' then this will
26-
# start listening for connections.
24+
# We typically don't want to accept incoming connections if the user is using a
25+
# SOCKS proxy, unless they have configured otherwise. If they eventually select
26+
# proxy 'none' or configure SOCKS listening then this will start listening for
27+
# connections.
2728
while shared.config.get('bitmessagesettings', 'socksproxytype')[0:5] == 'SOCKS' and not shared.config.getboolean('bitmessagesettings', 'sockslisten'):
2829
time.sleep(300)
2930

@@ -40,9 +41,10 @@ def run(self):
4041
sock.listen(2)
4142

4243
while True:
43-
# We don't want to accept incoming connections if the user is using
44-
# a SOCKS proxy. If the user eventually select proxy 'none' then
45-
# this will start listening for connections.
44+
# We typically don't want to accept incoming connections if the user is using a
45+
# SOCKS proxy, unless they have configured otherwise. If they eventually select
46+
# proxy 'none' or configure SOCKS listening then this will start listening for
47+
# connections.
4648
while shared.config.get('bitmessagesettings', 'socksproxytype')[0:5] == 'SOCKS' and not shared.config.getboolean('bitmessagesettings', 'sockslisten'):
4749
time.sleep(10)
4850
while len(shared.connectedHostsList) > 220:

0 commit comments

Comments
 (0)