class_sqlThread refactoring

Author: shportix

src/class_sqlThread.py

@@ -106,12 +106,6 @@ def upgrade_to_latest(self):
             Initialize upgrade level
         """
 
-        while self.sql_schema_version < self.max_level:
-            self._upgrade_one_level_sql_statement(self.sql_schema_version)
-
-    def upgrade_schema_if_old_version(self):
-        """ check settings table exists """
-
         query = "SELECT name FROM sqlite_master WHERE type='table' AND name='settings'"
         parameters = ()
         self.cur.execute(query, parameters)
@@ -128,9 +122,15 @@ def upgrade_schema_if_old_version(self):
 
             # initiate sql file
             self.initialize_sql("upg_sc_if_old_ver_1")
+            self.conn.commit()
         # After code refactoring, the possible status values for sent messages
         # have changed.
         self.initialize_sql("upg_sc_if_old_ver_2")
+        self.conn.commit()
+
+        while self.sql_schema_version < self.max_level:
+            self._upgrade_one_level_sql_statement(self.sql_schema_version)
+            self.conn.commit()
 
     def check_columns_can_store_binary_null(self):
         """
@@ -403,8 +403,6 @@ def run(self):  # pylint: disable=R0204, E501
 
         helper_startup.updateConfig()
 
-        self.db.upgrade_schema_if_old_version()
-
         self.db.upgrade_to_latest()
 
         self.db.check_columns_can_store_binary_null()