Bug: Spec Validation in dev Command (#68)

Author: bh2smith

src/commands/deploy.ts

@@ -26,7 +26,6 @@ export const deployCommand = new Command()
       console.error("OpenAPI specification validation failed.");
       return;
     }
-    const accountId = xMbSpec["account-id"];
 
     const pluginService = new PluginService();
     try {

src/commands/dev.ts

@@ -52,7 +52,11 @@ async function fetchAndValidateSpec(url: string): Promise<ValidationResult> {
   try {
     console.log("[Dev] Validating OpenAPI spec...");
     const validation = await validateAndParseOpenApiSpec(specUrl);
-    ({ isValid, accountId } = validation);
+    if (!validation) {
+      throw new Error("Invalid OpenAPI spec");
+    }
+    isValid = true;
+    accountId = validation["account-id"];
     console.log("[Dev] Validation result:", { isValid, accountId });
   } catch (error) {
     console.error(

src/utils/openapi.ts

@@ -51,9 +51,10 @@ export async function validateAndParseOpenApiSpec(
     }
 
     const xMbSpec = apiResponse["x-mb"];
-    isXMbSpec(xMbSpec);
-
-    return xMbSpec;
+    if (isXMbSpec(xMbSpec)) {
+      return xMbSpec;
+    }
+    throw new Error("Invalid OpenAPI spec");
   } catch (error) {
     console.error(
       "Unexpected error:",