Updated so that we use the connectionstring in SqlLookupRepository, and changed query so that we can handle the reseved name Key by enclosing it in brackets.

Author: Max Jacobs

Src/LookupUtility/LookupUtilityService.cs

@@ -23,8 +23,8 @@ public LookupUtilityService(ILookupRepository lookupRepository)
         public string GetValue(string list, string key, string defaultValue)
         {
             var dict = GetList(list);
-
-            if (!dict.TryGetValue(key, out string val))
+            string val;
+            if (!dict.TryGetValue(key, out val))
             {
                 return defaultValue;
             }
@@ -35,15 +35,15 @@ public string GetValue(string list, string key, string defaultValue)
         public string GetValue(string list, string key, bool throwIfNotExists = false, bool allowDefaults = false)
         {
             var dict = GetList(list);
-
-            if (!dict.TryGetValue(key, out string val))
+            string val;
+            if (!dict.TryGetValue(key, out val))
             {
                 if (throwIfNotExists)
                 {
                     throw new ArgumentException(string.Format("The specified property {0} does not exist in list {1}", key, list));
                 }
-
-                if (allowDefaults && dict.TryGetValue(DEFAULT_KEY, out string defaultValue))
+                string defaultValue;
+                if (allowDefaults && dict.TryGetValue(DEFAULT_KEY, out defaultValue))
                 {
                     return defaultValue;
                 }

Src/LookupUtility/Repository/SharepointLookupRepository.cs

@@ -32,10 +32,12 @@ public Dictionary<string, string> LoadList(string list)
 
             var dictionary = new Dictionary<string, string>();
 
+            object keyName;
+            object valueName;
             foreach (var item in collListItem)
             {
-                item.FieldValues.TryGetValue("Key", out object keyName);
-                item.FieldValues.TryGetValue("Value", out object valueName);
+                item.FieldValues.TryGetValue("Key", out keyName);
+                item.FieldValues.TryGetValue("Value", out valueName);
 
                 dictionary.Add(keyName.ToString(), valueName as string);
             }

Src/LookupUtility/Repository/SqlLookupRepository.cs

@@ -12,12 +12,12 @@ public class SqlLookupRepository : ILookupRepository
     {
         public Dictionary<string, string> LoadList(string list)
         {
-            string query = string.Format("SELECT Key, Value FROM {0}", list);
+            string query = string.Format("SELECT [Key], Value FROM {0}", list);
 
             var connectionString = ConfigurationManager.ConnectionStrings["SqlLookupRepository"].ConnectionString;
             var dictionary = new Dictionary<string, string>();
 
-            using (var con = new SqlConnection())
+            using (var con = new SqlConnection(connectionString))
             {
                 con.Open();
                 using (var cmd = new SqlCommand(query, con))