Skip to content
This repository was archived by the owner on Sep 17, 2021. It is now read-only.

Commit 31ce66e

Browse files
committed
Updating readme and launch position
1 parent 5723d8d commit 31ce66e

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ A VSCode extension to host the chrome devtools inside of a webview.
88
</a>
99
</p>
1010

11-
## Attach to a running chrome instance:
11+
## Attaching to a running chrome instance:
1212
![Demo1](demo.gif)
1313

14-
## Launch a chrome debugger project and use screencasting:
14+
## Launching a 'debugger for chrome' project and using screencast:
1515
![Demo2](demo2.gif)
1616

1717
# Using the extension
@@ -32,7 +32,9 @@ A VSCode extension to host the chrome devtools inside of a webview.
3232

3333
# Known Issues
3434
- Prototyping stage
35-
- Settings in the devtools are not persisted
35+
- Having the DevTools in a non-foreground tab can cause issues while debugging
36+
- This is due to VS Code suspending script execution of non-foreground webviews
37+
- The workaround is to put the DevTools in a split view tab so that they are always visible while open
3638
- Chrome browser extensions can sometimes cause the webview to terminate
3739

3840
# Developing the extension itself

demo2.gif

-17.9 KB
Loading

src/extension.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,12 @@ class DevToolsPanel {
173173
private _disposables: vscode.Disposable[] = [];
174174

175175
public static createOrShow(context: vscode.ExtensionContext, targetUrl: string) {
176-
const column = vscode.window.activeTextEditor ? vscode.window.activeTextEditor.viewColumn : undefined;
176+
const column = vscode.ViewColumn.Beside;
177177

178178
if (DevToolsPanel.currentPanel) {
179179
DevToolsPanel.currentPanel._panel.reveal(column);
180180
} else {
181-
const panel = vscode.window.createWebviewPanel('devtools-for-chrome', 'DevTools', column || vscode.ViewColumn.Two, {
181+
const panel = vscode.window.createWebviewPanel('devtools-for-chrome', 'DevTools', column, {
182182
enableScripts: true,
183183
enableCommandUris: true,
184184
retainContextWhenHidden: true

0 commit comments

Comments
 (0)