Merge branch 'master' into addLaunchOnDebugSessionStart

Author: andysterland

README.md

@@ -8,32 +8,43 @@ A VSCode extension to host the chrome devtools inside of a webview.
     </a>
 </p>
 
-![Demo](demo.gif)
+## Attach to a running chrome instance:
+![Demo1](demo.gif)
+
+## Launch a chrome debugger project and use screencasting:
+![Demo2](demo2.gif)
 
 # Using the extension
-- Start chrome with remote-debugging enabled on port 9222
-    - `chrome.exe --remote-debugging-port=9222`
-- Open the devtools inside VS Code 
-    - Either
-      - Run the `DevTools for Chrome: Attach to a target` command to attch to an instance of Chrome that's running
-      - Run the `DevTools for Chrome: Launch` command to launch Chrome and attach to it (you can navigate to whatever page you want)
+## Launching Chrome manually
+- Start chrome with no extensions and remote-debugging enabled on port 9222:
+    - `chrome.exe --disable-extensions --remote-debugging-port=9222`
+- Open the devtools inside VS Code:
+    - Run the command - `DevTools for Chrome: Attach to a target`
+    - Select a target from the drop down
+
+## Launching Chrome via the extension
+- Start chrome:
+    - Run the command - `DevTools for Chrome: Launch Chrome and then attach to a target`
+    - Navigate to whatever page you want
+- Open the devtools inside VS Code:
     - Select a target from the drop down
 
 
 # Known Issues
 - Prototyping stage
-- Settings are not persisted
+- Settings in the devtools are not persisted
+- Chrome browser extensions can sometimes cause the webview to terminate
 
 # Developing the extension itself
 
 - Start chrome with remote-debugging enabled on port 9222
-    - `chrome.exe --remote-debugging-port=9222`
+    - `chrome.exe --disable-extensions --remote-debugging-port=9222`
 - Run the extension 
     - `npm install`
     - `npm run watch` or `npm run build`
     - Open the folder in VSCode
     - `F5` to start debugging
 - Open the devtools 
-    - Run the `DevTools: Attach to a target` command
+    - Run the command - `DevTools for Chrome: Attach to a target`
     - Select a target from the drop down
 

demo2.gif

@@ -43,12 +43,12 @@
     "commands": [
       {
         "command": "devtools-for-chrome.launch",
-        "title": "Launch Chrome and the Chrome DevTools (in VS Code)",
+        "title": "Launch Chrome and then attach to a target",
         "category": "DevTools for Chrome"
       },
       {
         "command": "devtools-for-chrome.attach",
-        "title": "Attach the Chrome DevTools (in VS Code) to a target",
+        "title": "Attach to a target",
         "category": "DevTools for Chrome"
       }
     ],

package.json

@@ -69,7 +69,10 @@ export function existsSync(path: string): boolean {
 }
 
 export function launchLocalChrome(chromePath: string, chromePort: number, targetUrl: string) {
-    const chromeArgs = [`--remote-debugging-port=${chromePort}`];
+    const chromeArgs = [
+        '--disable-extensions',
+        `--remote-debugging-port=${chromePort}`
+    ];
 
     const chromeProc = cp.spawn(chromePath, chromeArgs, {
         stdio: 'ignore',