Skip to content

Commit 6bd977f

Browse files
wizzupjrepp
authored andcommitted
Cleaning up bash scripts and TODO section (#1)
* use /usr/bin/env instead of /bin/bash * readme : reformat TODO
1 parent f3a19a7 commit 6bd977f

File tree

11 files changed

+17
-15
lines changed

11 files changed

+17
-15
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ A docker image for building and running the StarCraft II API on Linux
55
This is a work in progress. Contributions welcome!
66

77
TODO:
8-
* Get unit tests working on s2client-game container
9-
* Automate the replay & Battle.net Cache population
10-
* Create a combined container for developers (with git, API and game)
11-
* Get some compose / swarm examples for doing larger training exercises
8+
* [ ] Get unit tests working on s2client-game container
9+
* [ ] Automate the replay & Battle.net Cache population
10+
* [ ] Create a combined container for developers (with git, API and game)
11+
* [ ] Get some compose / swarm examples for doing larger training exercises
1212

1313
# Summary
1414

build/all.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
2+
23
./clone.sh && ./make-container.sh

build/api-build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

33
# This script is intended to be embedded in the build container for
44
# automating the CMake / GNU make build process

build/clone.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

33
# This clones a clean copy of the repo
44
mkdir -p downloads

build/make-container.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

33
# This builds the container
44
docker build . -t s2client-api

docker_cleanup.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
2+
23
docker rm $(docker ps -qaf status=exited)

game/all.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

3-
./download.sh && ./unpack.sh && make-container.sh
3+
./download.sh && ./unpack.sh && ./make-container.sh

game/download.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

33
VERSION=3.16.1
44

game/make-container.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

33
# This builds the game container
44
docker build . -t s2client-game

game/unpack.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/bin/bash
1+
#!/usr/bin/env bash
22

33
# This unpacks all of the zip files automatically
44

0 commit comments

Comments
 (0)