Skip to content

Commit 1a18e02

Browse files
committed
remove setters in scene objects
1 parent 2975c48 commit 1a18e02

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

src/compas_model/models/model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,10 +350,10 @@ def add_elements(self, elements: list[Element], parent: Optional[Element] = None
350350
list[:class:`Element`]
351351
352352
"""
353-
nodes = []
353+
added_elements = []
354354
for element in elements:
355-
nodes.append(self.add_element(element, parent=parent))
356-
return nodes
355+
added_elements.append(self.add_element(element, parent=parent))
356+
return added_elements
357357

358358
def add_material(self, material: Material) -> None:
359359
"""Add a material to the model.

src/compas_model/scene/elementobject.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,6 @@ def __init__(
8686
def element(self) -> Element:
8787
return self.item
8888

89-
@element.setter
90-
def element(self, element: Element) -> None:
91-
self.item = element
92-
self._transformation = None
93-
9489
@property
9590
def transformation(self) -> Transformation:
9691
return self._transformation

src/compas_model/scene/modelobject.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ def __init__(
1818
self.show_elements = show_elements
1919
self.show_contacts = show_contacts
2020

21-
self.add_elements(**kwargs)
21+
self._add_elements(**kwargs)
2222

23-
def add_elements(self, **kwargs) -> None:
23+
def _add_elements(self, **kwargs) -> None:
2424
elements_group = self.add(Group(name="Elements", context=self.context))
2525
contacts_group = self.add(Group(name="Contacts", context=self.context))
2626

@@ -40,11 +40,6 @@ def add_elements(self, **kwargs) -> None:
4040
def model(self) -> Model:
4141
return self.item
4242

43-
@model.setter
44-
def model(self, model: Model) -> None:
45-
self.item = model
46-
self._transformation = None
47-
4843
@property
4944
def transformation(self) -> Transformation:
5045
return self._transformation

0 commit comments

Comments
 (0)