typing error material assignment and opposite vectors bug

Author: tomvanmele

CHANGELOG.md

@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Fixed typing error in `Element.material` assignment.
+* Changed (temporarily) `polygon_polygon_overlap` to not check for exactly opposite vectors.
+
 ### Removed
 
 

src/compas_model/algorithms/contacts.py

@@ -166,8 +166,9 @@ def polygon_polygon_overlap(a_points, a_normal, b_points, b_normal, tolerance, m
     """"""
     # normals should actually be exactly opposite
     # parallelity is not enough
-    if not is_opposite_vector_vector(a_normal, b_normal, tol=tolerance):
-        return
+
+    # if not is_opposite_vector_vector(a_normal, b_normal, tol=tolerance):
+    #     return
 
     # this ensures that a shared frame is used to do the interface calculations
     frame = Frame(*bestfit_frame_numpy(a_points + b_points))

src/compas_model/elements/element.py

@@ -160,7 +160,9 @@ def __init__(
         self._transformation = transformation
         self._geometry = geometry
         self._features = list(features or [])
-        self._material = material
+        self._material = None
+        if material:
+            self.material = material
 
         self._elementgeometry = None
         self._modelgeometry = None
@@ -213,8 +215,10 @@ def material(self) -> Union[Material, None]:
     def material(self, material: Union[Material, str]) -> None:
         if isinstance(material, Material):
             self._material = str(material.guid)
-        else:
+        elif isinstance(material, str):
             self._material = material
+        else:
+            raise TypeError("material must be a Material or a str")
 
     @property
     def parentnode(self) -> "ElementNode":
@@ -521,6 +525,7 @@ def apply_features(self) -> Union[Mesh, Brep]:
     # Transformations
     # ==========================================================================
 
+    @reset_computed
     def transform(self, transformation: Transformation) -> None:
         """Transforms the element.