Added test for listing verifications and fixed bug

Author: TealOcean

src/main/java/com/blockscore/models/results/Verification.java

@@ -3,7 +3,6 @@
 import com.blockscore.common.ValidityStatus;
 import com.blockscore.models.Details;
 import com.blockscore.models.Person;
-import com.blockscore.models.QuestionSet;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import org.jetbrains.annotations.NotNull;
 
@@ -24,7 +23,7 @@ public class Verification extends Person {
 
     @NotNull
     @JsonProperty("question_sets")
-    private List<QuestionSet> mQuestionSets;
+    private List<String> mQuestionSets;
 
     /**
      * Returns either valid or invalid and is the culmination of whether or not the passed
@@ -45,11 +44,11 @@ public Details getDetails() {
     }
 
     /**
-     * Gets the question sets associated with this verification record.
+     * Gets the question set ids associated with this verification record.
      * @return Question sets.
      */
     @NotNull
-    public List<QuestionSet> getQuestionSets() {
+    public List<String> getQuestionSets() {
         return mQuestionSets;
     }
 }

src/test/java/VerificationTest.java

@@ -34,6 +34,10 @@ public void verificationTest() throws ParseException {
         verification = apiClient.getVerification(verification.getId()).toBlocking().first();
         isVerificationValid(verification);
 
+        //Test listing verifications
+        List<Verification> verifications = apiClient.listVerificationsSync();
+        areVerificationsValid(verifications);
+
         //Test creation of a question set.
         QuestionSetRequest questionSetRequest = new QuestionSetRequest();
         questionSetRequest.setTimeLimit(100000).setVerificationId(verification.getId());
@@ -244,6 +248,17 @@ private Person createBadTestPerson() throws ParseException {
         return person;
     }
 
+    /**
+     * Checks for a valid verification list.
+     * @param verificationList Verifications under test.
+     */
+    private void areVerificationsValid(@Nullable final List<Verification> verificationList) {
+        Assert.assertNotNull(verificationList);
+        for (Verification verification : verificationList) {
+            isVerificationValid(verification);
+        }
+    }
+
     /**
      * Determines if the verification is valid.
      * @param verification Verification under test.
@@ -252,9 +267,9 @@ private void isVerificationValid(@NotNull final Verification verification) {
         Assert.assertNotNull(verification);
         Assert.assertNotNull(verification.getId());
         Assert.assertNotNull(verification.getDateOfBirth());
+        Assert.assertNotNull(verification.getQuestionSets());
 
         areDetailsValid(verification.getDetails());
-        areQuestionSetsValid(verification.getQuestionSets());
         isIdentificationValid(verification.getIdentification());
         isNameValid(verification.getName());
         isAddressValid(verification.getAddress());