Skip to content

Commit e6f210b

Browse files
Fix errors in db_helper (#60)
* Fix errors in db_helper * Update db_helper test
1 parent 760686a commit e6f210b

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

tests/test_map.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_fill_db_with_balances(mocker):
5555
assert db_insert_address_without_update_mock.call_args_list == [call('connector', 'bitcoin', 'addr1'), call('connector', 'bitcoin', 'addr2')]
5656
assert db_insert_balance_mock.call_args_list == [call('connector', 'bitcoin', '2010-01-01', 'addr1', 100), call('connector', 'bitcoin', '2010-01-01', 'addr2', 200)]
5757
assert db_update_circulation_mock.call_args_list == [call('connector', 'bitcoin', '2010-01-01', 300)]
58-
assert db_commit_mock.call_args_list == [call()]
58+
assert db_commit_mock.call_args_list == [call('connector')]
5959

6060
db_insert_address_without_update_mock.reset_mock()
6161
db_insert_snapshot_mock.reset_mock()
@@ -70,7 +70,7 @@ def test_fill_db_with_balances(mocker):
7070
assert db_insert_address_without_update_mock.call_args_list == [call('connector', 'ethereum', 'addr2')]
7171
assert db_insert_balance_mock.call_args_list == [call('connector', 'ethereum', '2010-01-01', 'addr2', 1)]
7272
assert db_update_circulation_mock.call_args_list == [call('connector', 'ethereum', '2010-01-01', 1)]
73-
assert db_commit_mock.call_args_list == [call()]
73+
assert db_commit_mock.call_args_list == [call('connector')]
7474

7575

7676
def test_apply_mapping(mocker):

tokenomics_decentralization/db_helper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def insert_ledger(conn, ledger):
3535

3636
try:
3737
cursor.execute("INSERT INTO ledgers(name) VALUES (?)", (ledger, ))
38-
commit_database()
38+
commit_database(conn)
3939
except sqlite3.IntegrityError as e:
4040
if 'UNIQUE constraint failed' in str(e):
4141
pass
@@ -63,7 +63,7 @@ def insert_entity(conn, ledger, entity):
6363
ledger_id = get_ledger_id(conn, ledger)
6464
try:
6565
cursor.execute("INSERT INTO entities(name, ledger_id) VALUES (?, ?)", (entity, ledger_id))
66-
commit_database()
66+
commit_database(conn)
6767
except sqlite3.IntegrityError as e:
6868
if 'UNIQUE constraint failed' in str(e):
6969
pass
@@ -92,7 +92,7 @@ def insert_update_address(conn, ledger, address, entity, is_contract):
9292
entity_id = cursor.execute("SELECT id FROM entities WHERE name=? AND ledger_id=?", (entity, ledger_id)).fetchone()[0]
9393

9494
try:
95-
cursor.execute("INSERT INTO addresses(name, ledger_id, entity_id, is_contract) VALUES (?, ?, ?)", (address, ledger_id, entity_id, is_contract))
95+
cursor.execute("INSERT INTO addresses(name, ledger_id, entity_id, is_contract) VALUES (?, ?, ?, ?)", (address, ledger_id, entity_id, is_contract))
9696
except sqlite3.IntegrityError as e:
9797
if 'UNIQUE constraint failed' in str(e):
9898
cursor.execute("UPDATE addresses SET entity_id=?, is_contract=? WHERE name=? AND ledger_id=?", (entity_id, is_contract, address, ledger_id))

tokenomics_decentralization/map.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def fill_db_with_addresses(conn, ledger):
2121
is_contract = 'is_contract' in info.keys() and info['is_contract']
2222

2323
db_hlp.insert_update_address(conn, ledger, addr, entity, is_contract)
24-
db_hlp.commit_database()
24+
db_hlp.commit_database(conn)
2525
except FileNotFoundError:
2626
return
2727

@@ -51,7 +51,7 @@ def fill_db_with_balances(conn, ledger, snapshot):
5151
db_hlp.insert_balance(conn, ledger, snapshot, address, balance)
5252

5353
db_hlp.update_circulation(conn, ledger, snapshot, circulation)
54-
db_hlp.commit_database()
54+
db_hlp.commit_database(conn)
5555
return
5656

5757

0 commit comments

Comments
 (0)