psbt: fix a (harmless) off-by-one assert check

jgriffiths · jgriffiths · commit 42f6948c3410 · 2025-12-03T22:03:58.000+13:00
diff --git a/main/utils/psbt.c b/main/utils/psbt.c
@@ -37,7 +37,7 @@ static bool key_iter_init(
     const struct wally_psbt* psbt, const size_t index, const bool is_input, const bool is_private, key_iter* iter)
 {
     JADE_ASSERT(psbt);
-    JADE_ASSERT(index <= (is_input ? psbt->num_inputs : psbt->num_outputs));
+    JADE_ASSERT(index < (is_input ? psbt->num_inputs : psbt->num_outputs));
     JADE_ASSERT(iter);
     iter->psbt = psbt;
     iter->index = index;

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ static bool key_iter_init(`
`37`	`37`	`const struct wally_psbt* psbt, const size_t index, const bool is_input, const bool is_private, key_iter* iter)`
`38`	`38`	`{`
`39`	`39`	`JADE_ASSERT(psbt);`
`40`		`- JADE_ASSERT(index <= (is_input ? psbt->num_inputs : psbt->num_outputs));`
	`40`	`+ JADE_ASSERT(index < (is_input ? psbt->num_inputs : psbt->num_outputs));`
`41`	`41`	`JADE_ASSERT(iter);`
`42`	`42`	`iter->psbt = psbt;`
`43`	`43`	`iter->index = index;`