Unable to Compile?

[martindale]

Despite linking the latest secp256k1, I'm unable to compile this as-is?

$   make CXXFLAGS="-I../secp256k1/install/usr/local/include -L../secp256k1/install/usr/local/lib -static"
g++ -O2 -Wall -I../secp256k1/install/usr/local/include -L../secp256k1/install/usr/local/lib -static -I. contracthashtool.c stolen.cpp uint256.cpp crypto/ripemd160.cpp crypto/sha2.cpp -o contracthashtool -lsecp256k1
contracthashtool.c: In function ‘int main(int, char**)’:
contracthashtool.c:246:75: error: cannot convert ‘unsigned char*’ to ‘secp256k1_pubkey_t*’ for argument ‘2’ to ‘int secp256k1_ec_pubkey_tweak_add(const secp256k1_context_t*, secp256k1_pubkey_t*, const unsigned char*)’
     if (secp256k1_ec_pubkey_tweak_add(secp256k1_ctx, keys_work[i], 33, res) == 0) {
                                                                           ^
contracthashtool.c:290:67: error: cannot convert ‘unsigned char*’ to ‘secp256k1_pubkey_t*’ for argument ‘2’ to ‘int secp256k1_ec_pubkey_create(const secp256k1_context_t*, secp256k1_pubkey_t*, const unsigned char*)’
   if (secp256k1_ec_pubkey_create(secp256k1_ctx, pub, &len, priv, 1) != 1 || len != 33)
                                                                   ^
make: *** [all] Error 1

Seems like this needs to be pushed upstream or a target version specified?

[sipa]

Known problem, will fix soon!

[gmaxwell]

You can check out libsecp256k1 from about a month ago and it'll work fine. The API for libsecp256k1 changed a couple weeks ago.

[martindale]

Ah, great – thanks for the tip, @gmaxwell! That fixed my issue.

[harding]

FYI, for anyone else encountering this problem while trying to get contracthashtool compiling, the highest secp256k1 commit that worked for me was bitcoin-core/secp256k1@cb04ab5

(The next merge after that, bitcoin-core/secp256k1@eeab823, gives me output similar to what Eric posted above.)

Looking at the dates, I suspect that this is actually a different API break than Eric reported, but since this issue is still open---and it's still an "unable to compile" error---I'm posting here. Let me know if I should open a separate issue.

[sipa]

Thanks David. Indeed, the libsecp256k1 API is still undergoing some changes before we finalize and release. I'll update contracthashtool again when that's done. In the mean time, you probably want to stick to a fixed commit.