testing: Improve error reporting in grpcwebproxy

Author: cdecker

libs/gl-testing/gltesting/grpcweb.py

@@ -154,15 +154,15 @@ def auth(self, request: Request) -> bool:
         ts = request.headers.get("glts", None)
 
         if not pk:
-            self.logger.warn(f"Missing public key header")
+            self.logger.warning(f"Missing public key header: headers={request.headers}")
             return False
 
         if not sig:
-            self.logger.warn(f"Missing signature header")
+            self.logger.warning(f"Missing signature header: headers={request.headers}")
             return False
 
         if not ts:
-            self.logger.warn(f"Missing timestamp header")
+            self.logger.warning(f"Missing timestamp header: headers={request.headers}")
             return False
 
         # TODO Check the signature.
@@ -212,12 +212,15 @@ def proxy(self, request: Request):
         )
 
         try:
+            self.logger.debug(f"Sending grpc request req={req}, payload={content} to url={url}")
             res = client.send(req)
             # Capture the error from header and send it in the body as well
-            if res.headers.get("grpc-status", "0") != "0":
-                grpc_status = res.headers.get("grpc-status")
+            status = res.headers.get("grpc-status", "0")
+            logging.debug(f"Server returned grpc-status={status}")
+            if status != "0":
                 error_message = res.headers.get("grpc-message", "None")
-                self.logger.warning(f"gRPC status code received: {grpc_status}")
+                self.logger.error(f"Received grpc-status={status}, error={error_message}")
+                self.logger.warning(f"gRPC status code received: {status}")
                 self.logger.warning(f"gRPC message received: {error_message}")
                 error = error_message.encode("utf-8")
                 error_res = struct.pack("!cI", request.flags, len(error)) + error

libs/gl-testing/gltesting/node.py

@@ -95,6 +95,7 @@ def __init__(
             '--dev-bitcoind-poll=5',
             '--dev-fast-gossip',
             '--offline',
+            '--allow-deprecated-apis=true',
             #'--experimental-anchors',
             '--developer',  # TODO Make this multi-version capable
         ]

libs/gl-testing/pyproject.toml

@@ -10,7 +10,7 @@ dependencies = [
     "gl-client",
     "grpcio-tools>=1.66",
     "grpcio>=1.66.0",
-    "httpx[http2]>=0.28",
+    "httpx[http2]==0.27.2",
     "purerpc>=0.8.0",
     "pyln-client==24.2",
     "pyln-testing==24.2",

libs/gl-testing/tests/test_grpc_web.py

@@ -47,7 +47,7 @@ def test_node_grpc_web(scheduler, node_grpc_web_proxy, clients):
     c = clients.new()
     c.register(configure=True)
     n = c.node()
-    _s =    c.signer().run_in_thread()
+    _s = c.signer().run_in_thread()
     info = n.get_info()
 
     # Now extract the TLS certificates, so we can sign the payload.