bindings: optimize error handling + typos fix

Author: KyrylR

lwk_bindings/src/error.rs

@@ -177,6 +177,30 @@ impl From<elements::bitcoin::secp256k1::Error> for LwkError {
     }
 }
 
+impl From<elements::bitcoin::key::FromSliceError> for LwkError {
+    fn from(value: elements::bitcoin::key::FromSliceError) -> Self {
+        LwkError::Generic {
+            msg: format!("{value:?}"),
+        }
+    }
+}
+
+impl From<elements::bitcoin::key::ParsePublicKeyError> for LwkError {
+    fn from(value: elements::bitcoin::key::ParsePublicKeyError) -> Self {
+        LwkError::Generic {
+            msg: format!("{value:?}"),
+        }
+    }
+}
+
+impl From<elements::secp256k1_zkp::Error> for LwkError {
+    fn from(value: elements::secp256k1_zkp::Error) -> Self {
+        LwkError::Generic {
+            msg: format!("{value:?}"),
+        }
+    }
+}
+
 impl From<elements::bitcoin::bip32::Error> for LwkError {
     fn from(value: elements::bitcoin::bip32::Error) -> Self {
         LwkError::Generic {

lwk_bindings/src/types/public_key.rs

@@ -48,9 +48,7 @@ impl FromStr for PublicKey {
     type Err = LwkError;
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
-        let inner = elements::bitcoin::PublicKey::from_str(s).map_err(|e| LwkError::Generic {
-            msg: format!("Invalid public key: {e}"),
-        })?;
+        let inner = elements::bitcoin::PublicKey::from_str(s)?;
         Ok(Self { inner })
     }
 }
@@ -66,19 +64,14 @@ impl PublicKey {
     /// See [`elements::bitcoin::PublicKey::from_slice`].
     #[uniffi::constructor]
     pub fn from_bytes(bytes: &[u8]) -> Result<Arc<Self>, LwkError> {
-        let inner =
-            elements::bitcoin::PublicKey::from_slice(bytes).map_err(|e| LwkError::Generic {
-                msg: format!("Invalid public key: {e}"),
-            })?;
+        let inner = elements::bitcoin::PublicKey::from_slice(bytes)?;
         Ok(Arc::new(PublicKey { inner }))
     }
 
     /// Creates a `PublicKey` from a hex string.
     #[uniffi::constructor]
     pub fn from_hex(hex: &str) -> Result<Arc<Self>, LwkError> {
-        let bytes = Vec::<u8>::from_hex(hex).map_err(|e| LwkError::Generic {
-            msg: format!("Invalid hex: {e}"),
-        })?;
+        let bytes = Vec::<u8>::from_hex(hex)?;
         Self::from_bytes(&bytes)
     }
 

lwk_bindings/src/types/tx_sequence.rs

@@ -2,7 +2,7 @@ use crate::LwkError;
 
 use std::sync::Arc;
 
-/// Bitcoin transaction input sequence number.
+/// Transaction input sequence number.
 ///
 /// See [`elements::Sequence`] for more details.
 #[derive(uniffi::Object, PartialEq, Eq, Debug, Clone, Copy)]