musig: remove unnecessary constant time normalize in combine

jonasnick · jonasnick · commit 7d2f7bb64b06 · 2021-05-13T18:02:29.000Z
diff --git a/src/modules/musig/main_impl.h b/src/modules/musig/main_impl.h
@@ -135,7 +135,7 @@ int secp256k1_musig_pubkey_combine(const secp256k1_context* ctx, secp256k1_scrat
         return 0;
     }
     secp256k1_ge_set_gej(&pkp, &pkj);
-    secp256k1_fe_normalize(&pkp.y);
+    secp256k1_fe_normalize_var(&pkp.y);
     pk_parity = secp256k1_extrakeys_ge_even_y(&pkp);
     secp256k1_xonly_pubkey_save(combined_pk, &pkp);
 

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ int secp256k1_musig_pubkey_combine(const secp256k1_context* ctx, secp256k1_scrat`
`135`	`135`	`return 0;`
`136`	`136`	`}`
`137`	`137`	`secp256k1_ge_set_gej(&pkp, &pkj);`
`138`		`- secp256k1_fe_normalize(&pkp.y);`
	`138`	`+ secp256k1_fe_normalize_var(&pkp.y);`
`139`	`139`	`pk_parity = secp256k1_extrakeys_ge_even_y(&pkp);`
`140`	`140`	`secp256k1_xonly_pubkey_save(combined_pk, &pkp);`
`141`	`141`