Update SimplicityHL to latest released version #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mod merkle` was removed in 24b11af but the file it refers to was left hanging around. This results in an unused code warning. With this change, I can run a clean cargo +nightly clippy --all-targets --workspace --all-features --all -- -D warnings
Contributor
Author
|
cc @canndrew @uncomputable (if you're around) |
delta1
reviewed
Nov 21, 2025
Cargo.toml
Outdated
| itertools = "0.13.0" | ||
| #simplicityhl = "0.2.0" | ||
| simplicityhl = { package = "simfony", git = "https://github.com/BlockstreamResearch/simplicityhl", rev = "d5284014e9f67593e50b272f1f676ea8d09f6ec8" } | ||
| simplicityhl = { version = "0.3.0", path = "/home/apoelstra/code/BlockstreamResearch/SimplicityHL/master" } |
There was a problem hiding this comment.
This isn't compiling :)
Suggested change
| simplicityhl = { version = "0.3.0", path = "/home/apoelstra/code/BlockstreamResearch/SimplicityHL/master" } | |
| simplicityhl = { version = "0.3.0" } |
apoelstra
force-pushed
the
2025-11/update-simplicityhl
branch
from
95f10ae to
28e775f
Compare
These are stylistic things that have no effect and don't require moving whole blocks of code around.
This updates a couple APIs. Most notably it breaks our ability to read a value from the output frame of a jet in a reasonable-efficient way; however, it does give us the tools we need to just execute the jet in the bit machine.
apoelstra
force-pushed
the
2025-11/update-simplicityhl
branch
from
28e775f to
66e1a6a
Compare
This was referenced Nov 24, 2025
Contributor
Author
|
I am no longer going to test the docs.rs deployment on this repo. rustc made an apparently-permanent breaking change in rust-lang/rust#138907 and now multiple dependencies do not build with the docsrs flags on. There are hundreds of linked issues to that one but nobody is budging. What a joke. In particular: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should unblock #56
After this and #56 we should cut a new release and attempt to update the production site.