Reduce volume checks and print point gain

Reduced the amount of volume checks during the countdown at the start of a game. This commit also changes the chat messages that is displayed at the start of the game to show how many points there are to gain instead of the total point pool size.

Author: Bloo-dev

data/stack_attack_arena/functions/round/starting.mcfunction

@@ -4,9 +4,9 @@
 # called by stack_attack_arena:round/timer
 
 # do a countdown
-execute if score @s sat_round_timer matches -3 run function stack_attack_arena:round/timer/3
-execute if score @s sat_round_timer matches -2 run function stack_attack_arena:round/timer/2
-execute if score @s sat_round_timer matches -1 run function stack_attack_arena:round/timer/1
+execute if score @s sat_round_timer matches -3 as @a[tag=sat_in_game,dx=14,dy=255,dz=14] run function stack_attack_arena:round/timer/3
+execute if score @s sat_round_timer matches -2 as @a[tag=sat_in_game,dx=14,dy=255,dz=14] run function stack_attack_arena:round/timer/2
+execute if score @s sat_round_timer matches -1 as @a[tag=sat_in_game,dx=14,dy=255,dz=14] run function stack_attack_arena:round/timer/1
 
 # end countdown, also set arena state to 2 ("running")
 execute if score @s sat_round_timer matches 0 run function stack_attack_arena:round/timer/go

data/stack_attack_arena/functions/round/timer/1.mcfunction

@@ -4,7 +4,7 @@
 # called by stack_attack_arena:round/starting
 
 # title
-title @a[tag=sat_in_game,dx=14,dy=255,dz=14] title ["",{"text":"1","color":"red"}]
+title @s title ["",{"text":"1","color":"red"}]
 
 # sound
-execute as @a[tag=sat_in_game,dx=14,dy=255,dz=14] positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 0.6
+execute as @s positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 0.6

data/stack_attack_arena/functions/round/timer/2.mcfunction

@@ -4,7 +4,7 @@
 # called by stack_attack_arena:round/starting
 
 # title
-title @a[tag=sat_in_game,dx=14,dy=255,dz=14] title ["",{"text":"2","color":"yellow"}]
+title @s title ["",{"text":"2","color":"yellow"}]
 
 # sound
-execute as @a[tag=sat_in_game,dx=14,dy=255,dz=14] positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 0.6
+execute as @s positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 0.6

data/stack_attack_arena/functions/round/timer/3.mcfunction

@@ -4,7 +4,7 @@
 # called by stack_attack_arena:round/starting
 
 # title
-title @a[tag=sat_in_game,dx=14,dy=255,dz=14] title ["",{"text":"3","color":"green"}]
+title @s title ["",{"text":"3","color":"green"}]
 
 # sound
-execute as @a[tag=sat_in_game,dx=14,dy=255,dz=14] positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 0.6
+execute as @s positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 0.6

data/stack_attack_arena/functions/round/timer/announcements.mcfunction

@@ -0,0 +1,19 @@
+# Countdown
+# @s = players in arenas with sat_arena_state 1, sat_round_timer=0
+# at arenas with sat_arena_state 1, sat_round_timer=0
+# called by stack_attack_arena:round/timer/go
+say ran
+# title
+title @s title ["",{"text":"GO!","color":"blue"}]
+
+# sound
+execute as @s positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 1.2
+
+# calculate points that might be gained by winning
+scoreboard players operation point_gain sat_match_value = match_value sat_match_value
+scoreboard players operation point_gain sat_match_value -= @s sat_match_value
+
+# send private chat message
+execute if score point_gain sat_match_value matches 2.. run tellraw @s ["",{"text":"["},{"text":"S","color":"yellow"},{"text":"tack ","color":"light_purple"},{"text":"A","color":"blue"},{"text":"ttack","color":"green"},{"text":"] ","color":"none"},{"text":"Ready, Set, Stack! A win will gain you ","color":"green"},{"score":{"name":"point_gain","objective":"sat_match_value"}},{"text":" points!","color":"green"}]
+execute if score point_gain sat_match_value matches 1 run tellraw @s ["",{"text":"["},{"text":"S","color":"yellow"},{"text":"tack ","color":"light_purple"},{"text":"A","color":"blue"},{"text":"ttack","color":"green"},{"text":"] ","color":"none"},{"text":"Ready, Set, Stack! A win will gain you ","color":"green"},{"score":{"name":"point_gain","objective":"sat_match_value"}},{"text":" point!","color":"green"}]
+execute if score point_gain sat_match_value matches 0 run tellraw @s ["",{"text":"["},{"text":"S","color":"yellow"},{"text":"tack ","color":"light_purple"},{"text":"A","color":"blue"},{"text":"ttack","color":"green"},{"text":"] ","color":"none"},{"text":"Ready, Set, Stack! A win will ","color":"green"},{"text":"not ","color":"none"},{"text":"gain you any points. ","color":"green"}]

data/stack_attack_arena/functions/round/timer/go.mcfunction

@@ -2,16 +2,16 @@
 # @s = arenas with sat_arena_state 1, sat_round_timer=0
 # at @s
 # called by stack_attack_arena:round/starting
+say go
+# calculate point gain potential for tellraw
+scoreboard players operation match_value sat_match_value = @s sat_match_value
 
-# title
-title @a[tag=sat_in_game,dx=14,dy=255,dz=14] title ["",{"text":"GO!","color":"blue"}]
+# show announcements
+execute as @a[tag=sat_in_game,dx=14,dy=255,dz=14] run function stack_attack_arena:round/timer/announcements
 
-# sound
-execute as @a[tag=sat_in_game,dx=14,dy=255,dz=14] positioned ~6.5 ~2 ~6.5 run playsound minecraft:block.note_block.pling voice @s ~ ~ ~ 1 1.2
-
-# announce pot size to participating players
-execute if score @s sat_match_value matches 2.. run tellraw @a[tag=sat_in_game,dx=14,dy=255,dz=14] ["",{"text":"["},{"text":"S","color":"yellow"},{"text":"tack ","color":"light_purple"},{"text":"A","color":"blue"},{"text":"ttack","color":"green"},{"text":"] ","color":"none"},{"text":"Ready, Set, Stack! There are ","color":"green"},{"score":{"name":"@s","objective":"sat_match_value"}},{"text":" points in the pot!","color":"green"}]
-execute if score @s sat_match_value matches 1 run tellraw @a[tag=sat_in_game,dx=14,dy=255,dz=14] ["",{"text":"["},{"text":"S","color":"yellow"},{"text":"tack ","color":"light_purple"},{"text":"A","color":"blue"},{"text":"ttack","color":"green"},{"text":"] ","color":"none"},{"text":"Ready, Set, Stack! There is ","color":"green"},{"score":{"name":"@s","objective":"sat_match_value"}},{"text":" point in the pot!","color":"green"}]
+# reset fake players
+scoreboard players reset match_value sat_match_value
+scoreboard players reset point_gain sat_match_value
 
 # update sat_arena_state
 scoreboard players set @s sat_arena_state 2