v1.3.3 bugfix

readback_cell_V and readback_ai_v frame index fix

Author: mishakh

LICENSE

@@ -1,6 +1,6 @@
 BSD 3-Clause License
 
-Copyright (c) 2023, Bloomy Controls Inc.
+Copyright (c) 2024, Bloomy Controls Inc.
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "BS1200_driver"
-version = "1.3.2"
+version = "1.3.3"
 authors = [{ name = "Mikhail Kharitonov", email = "[email protected]"}]
 description= "Python interface to the Bloomy BS1200"
 readme = "README.md"

src/bs1200/driver.py

@@ -246,8 +246,7 @@ def readback_cell_V(self, boxid: int, channel: int) -> float:
                 readbacks = [self.rx_cache[288+boxid], 
                              self.rx_cache[304+boxid], 
                              self.rx_cache[320+boxid]]
-                frame_i = channel // 4
-                cell_i = (channel-1) % 4
+                frame_i, cell_i  = (channel-1) // 4, (channel-1) % 4
                 rx_msg = readbacks[frame_i]
                 cell_volts = self.scale_volts(unpack('<H', rx_msg.data[cell_i*2:cell_i*2+2])[0], True)
                 return cell_volts
@@ -359,8 +358,7 @@ def readback_ai_v(self, boxid: int, channel: int) -> float:
             try:
                 readbacks = [self.rx_cache[672+boxid], 
                             self.rx_cache[688+boxid]]
-                frame_i = channel // 4
-                cell_i = (channel-1) % 4
+                frame_i, cell_i  = (channel-1) // 4, (channel-1) % 4
                 rx_msg = readbacks[frame_i]
 
                 ai_volts = self.scale_volts(unpack('<H', rx_msg.data[cell_i*2:cell_i*2+2])[0], True)