Add typesize to dparams; remove free for codecs

Author: lshaw8317

blosc/blosc2.c

@@ -1169,6 +1169,7 @@ int fill_codec(blosc2_codec *codec) {
     return BLOSC2_ERROR_FAILURE;
   }
 
+  /* If ever add .free function in future for codec params
   codecparams_info *info2 = dlsym(lib, "info2");
   if (info2 != NULL) {
     // New plugin (e.g. openzl) with free function for codec_params defined
@@ -1178,7 +1179,8 @@ int fill_codec(blosc2_codec *codec) {
   else{
     codec->free = NULL;
   }
-
+  */
+ 
   return BLOSC2_ERROR_SUCCESS;
 }
 
@@ -4630,6 +4632,7 @@ void blosc2_free_ctx(blosc2_context* context) {
       return;
     }
   }
+  /* May be needed if codec_params ever contains nested objects
   if (context->codec_params != NULL) {
     int rc;
     for (int i = 0; i < g_ncodecs; ++i) {
@@ -4639,7 +4642,7 @@ void blosc2_free_ctx(blosc2_context* context) {
           if (fill_codec(&g_codecs[i]) < 0) {
             BLOSC_TRACE_ERROR("Could not load codec %d.", g_codecs[i].compcode);
             return BLOSC2_ERROR_CODEC_SUPPORT;
-          }
+          } 
         }
         if (g_codecs[i].free == NULL){
           // no free func, codec_params is simple
@@ -4659,6 +4662,7 @@ void blosc2_free_ctx(blosc2_context* context) {
       return;
     }
   }
+  */
   if (context->prefilter != NULL) {
     my_free(context->preparams);
   }
@@ -4702,6 +4706,7 @@ int blosc2_ctx_get_dparams(blosc2_context *ctx, blosc2_dparams *dparams) {
   dparams->schunk = ctx->schunk;
   dparams->postfilter = ctx->postfilter;
   dparams->postparams = ctx->postparams;
+  dparams->typesize = ctx->typesize;
 
   return BLOSC2_ERROR_SUCCESS;
 }

doc/reference/plugins.rst

@@ -22,7 +22,6 @@ Codecs
    :members:
 
 .. doxygenfunction:: blosc2_register_codec
-.. doxygenfunction:: blosc2_codec_create
 
 Tuners
 ------

examples/urcodecs.c

@@ -105,7 +105,6 @@ int main(void) {
   udcodec.compname = "udcodec";
   udcodec.encoder = codec_encoder;
   udcodec.decoder = codec_decoder;
-  udcodec.free = NULL;
 
   int rc = blosc2_register_codec(&udcodec);
   if (rc < 0) {

include/blosc2.h

@@ -1226,12 +1226,15 @@ typedef struct {
   //!< The postfilter function.
   blosc2_postfilter_params *postparams;
   //!< The postfilter parameters.
+  int32_t typesize;
+  //!< The type size (8).
 } blosc2_dparams;
 
 /**
  * @brief Default struct for decompression params meant for user initialization.
  */
-static const blosc2_dparams BLOSC2_DPARAMS_DEFAULTS = {1, NULL, NULL, NULL};
+static const blosc2_dparams BLOSC2_DPARAMS_DEFAULTS = {1, NULL, NULL, NULL, 8};
+
 
 /**
  * @brief Create a context for @a *_ctx() compression functions.
@@ -2408,8 +2411,8 @@ typedef struct {
   //!< The codec encoder that is used during compression.
   blosc2_codec_decoder_cb decoder;
   //!< The codec decoder that is used during decompression.
-  int (*free)(void* codec_params);
-  //!< Free the codec_params stored in blosc2_context.
+  // int (*free)(void* codec_params);
+  // //!< Free the codec_params stored in blosc2_context.
 } blosc2_codec;
 
 /**

plugins/codecs/codecs-registry.c

@@ -11,6 +11,7 @@
 #include "blosc2.h"
 
 void register_codecs(void) {
+  // May add .free func in future
 
   blosc2_codec ndlz;
   ndlz.compcode = BLOSC_CODEC_NDLZ;
@@ -19,7 +20,7 @@ void register_codecs(void) {
   ndlz.encoder = &ndlz_compress;
   ndlz.decoder = &ndlz_decompress;
   ndlz.compname = "ndlz";
-  ndlz.free = NULL;
+  // ndlz.free = NULL; 
   register_codec_private(&ndlz);
 
   blosc2_codec zfp_acc;
@@ -28,7 +29,7 @@ void register_codecs(void) {
   zfp_acc.complib = BLOSC_CODEC_ZFP_FIXED_ACCURACY;
   zfp_acc.encoder = &zfp_acc_compress;
   zfp_acc.decoder = &zfp_acc_decompress;
-  zfp_acc.free = NULL;
+  // zfp_acc.free = NULL;
   zfp_acc.compname = "zfp_acc";
   register_codec_private(&zfp_acc);
 
@@ -38,7 +39,7 @@ void register_codecs(void) {
   zfp_prec.complib = BLOSC_CODEC_ZFP_FIXED_PRECISION;
   zfp_prec.encoder = &zfp_prec_compress;
   zfp_prec.decoder = &zfp_prec_decompress;
-  zfp_prec.free = NULL;
+  // zfp_prec.free = NULL;
   zfp_prec.compname = "zfp_prec";
   register_codec_private(&zfp_prec);
 
@@ -49,7 +50,7 @@ void register_codecs(void) {
   zfp_rate.encoder = &zfp_rate_compress;
   zfp_rate.decoder = &zfp_rate_decompress;
   zfp_rate.compname = "zfp_rate";
-  zfp_rate.free = NULL;
+  // zfp_rate.free = NULL;
   register_codec_private(&zfp_rate);
 
   blosc2_codec openhtj2k;
@@ -58,7 +59,7 @@ void register_codecs(void) {
   openhtj2k.complib = BLOSC_CODEC_OPENHTJ2K;
   openhtj2k.encoder = NULL;
   openhtj2k.decoder = NULL;
-  openhtj2k.free = NULL;
+  // openhtj2k.free = NULL;
   openhtj2k.compname = "openhtj2k";
   register_codec_private(&openhtj2k);
 
@@ -68,7 +69,7 @@ void register_codecs(void) {
   grok.complib = BLOSC_CODEC_GROK;
   grok.encoder = NULL;
   grok.decoder = NULL;
-  grok.free = NULL;
+  // grok.free = NULL;
   grok.compname = "grok";
   register_codec_private(&grok);
 
@@ -78,7 +79,7 @@ void register_codecs(void) {
   openzl.complib = BLOSC_CODEC_OPENZL;
   openzl.encoder = NULL;
   openzl.decoder = NULL;
-  openzl.free = NULL;
+  // openzl.free = NULL;
   openzl.compname = "openzl";
   register_codec_private(&openzl);
 }

tests/test_urcodecs.c

@@ -164,7 +164,6 @@ CUTEST_TEST_TEST(urcodecs) {
   udcodec.compname = "arange";
   udcodec.version = 1;
   udcodec.encoder = codec_encoder;
-  udcodec.free = NULL;
   if (correct_backward) {
     udcodec.compcode = 250;
     udcodec.complib = 250;