fix: eslint warnings, rendering legacy chunks for carthing

Author: BluDood

client/eslint.config.js client/eslint.config.mjsclient/eslint.config.js renamed to client/eslint.config.mjs

@@ -64,6 +64,14 @@ const Menu: React.FC = () => {
     }
   ]
 
+  function onWheel(e: WheelEvent<HTMLDivElement>) {
+    if (e.deltaX < 0) {
+      setSelected(s => (s - 1 + elements.length) % elements.length)
+    } else if (e.deltaX > 0) {
+      setSelected(s => (s + 1) % elements.length)
+    }
+  }
+
   useEffect(() => {
     function listener(e: KeyboardEvent) {
       if (e.key === 'm') {
@@ -99,14 +107,6 @@ const Menu: React.FC = () => {
     shownRef.current = shown
   }, [shown, setBlurred])
 
-  function onWheel(e: WheelEvent<HTMLDivElement>) {
-    if (e.deltaX < 0) {
-      setSelected(s => (s - 1 + elements.length) % elements.length)
-    } else if (e.deltaX > 0) {
-      setSelected(s => (s + 1) % elements.length)
-    }
-  }
-
   useEffect(() => {
     const listener = (e: globalThis.WheelEvent) => {
       if (shownRef.current) {

client/src/components/Menu/Menu.tsx

@@ -12,7 +12,8 @@ export default defineConfig({
   plugins: [
     react(),
     legacy({
-      targets: ['Chrome 69']
+      targets: ['Chrome 69'],
+      renderModernChunks: false
     })
   ],
   base: '/usr/share/qt-superbird-app/webapp/',

client/vite.config.ts

@@ -1,19 +1,29 @@
 import js from '@eslint/js'
+import globals from 'globals'
 import tseslint from 'typescript-eslint'
 import { defineConfig, globalIgnores } from 'eslint/config'
+import react from 'eslint-plugin-react'
 
 export default defineConfig([
   globalIgnores(['node_modules/', 'dist/', 'out/', 'client/']),
   {
-    files: ['**/*.ts'],
-    plugins: { js },
-    extends: ['js/recommended']
+    files: ['**/*.{ts,tsx}'],
+    plugins: { js, react },
+    extends: ['js/recommended'],
+    languageOptions: {
+      globals: globals.browser
+    }
   },
   tseslint.configs.recommended,
+  react.configs.flat.recommended,
   {
     rules: {
       // 'no-async-promise-executor': 'off',
       // '@typescript-eslint/no-explicit-any': 'off'
+      'react/react-in-jsx-scope': 'off'
+    },
+    settings: {
+      react: { version: 'detect' }
     }
   }
 ])

eslint.config.js eslint.config.mjseslint.config.js renamed to eslint.config.mjs

@@ -104,23 +104,23 @@ function importAddon() {
     if (process.arch === 'x64') {
       try {
         return require('node-nowplaying-win32-x64-msvc')
-      } catch (e) {
+      } catch {
         log('Failed to import native addon', 'Native')
         return null
       }
     }
   } else if (process.platform === 'darwin') {
     try {
       return require('node-nowplaying-darwin-universal')
-    } catch (e) {
+    } catch {
       log('Failed to import native addon', 'Native')
       return null
     }
   } else if (process.platform === 'linux') {
     if (process.arch === 'x64') {
       try {
         return require('node-nowplaying-linux-x64-gnu')
-      } catch (e) {
+      } catch {
         log('Failed to import native addon', 'Native')
         return null
       }
@@ -180,17 +180,14 @@ export function filterData(data: NowPlayingMessage): PlaybackData | null {
   return playbackData
 }
 
-interface NativeConfig {}
-
 class NativeHandler extends BasePlaybackHandler {
   name: string = 'native'
   requiresInternet: boolean = false
 
-  config: NativeConfig | null = null
   instance: NowPlaying | null = null
   current: NowPlayingMessage | null = null
 
-  async setup(config: NativeConfig): Promise<void> {
+  async setup(): Promise<void> {
     log('Setting up', 'Native')
 
     const addon = importAddon()
@@ -209,7 +206,6 @@ class NativeHandler extends BasePlaybackHandler {
     await instance.subscribe()
 
     this.instance = instance
-    this.config = config
   }
 
   async cleanup(): Promise<void> {
@@ -220,9 +216,7 @@ class NativeHandler extends BasePlaybackHandler {
     this.removeAllListeners()
   }
 
-  async validateConfig(config: unknown): Promise<boolean> {
-    const {} = config as NativeConfig
-
+  async validateConfig(): Promise<boolean> {
     return true
   }
 

src/main/lib/playback/native.ts

@@ -29,7 +29,7 @@ export async function uploadScreensaverImage() {
           'Image size exceeds the 5MB limit. Please select a smaller image.'
       }
     }
-  } catch (error) {
+  } catch {
     return {
       success: false,
       error: 'file_read_error',
@@ -51,7 +51,7 @@ export async function uploadScreensaverImage() {
     updateScreensaverImage()
 
     return { success: true }
-  } catch (error) {
+  } catch {
     return {
       success: false,
       error: 'save_error',

src/main/lib/screensaver.ts

@@ -131,6 +131,6 @@ if (process.contextIsolated) {
     console.error(error)
   }
 } else {
-  // @ts-ignore (define in dts)
+  // @ts-expect-error (define in dts)
   window.api = api
 }

src/preload/index.ts

@@ -1,4 +1,4 @@
-import React, { useEffect } from 'react'
+import React from 'react'
 import styles from './Native.module.css'
 
 interface NativeProps {
@@ -9,8 +9,8 @@ const Native: React.FC<NativeProps> = ({ onStepComplete }) => {
   return (
     <div className={styles.native}>
       <p>
-        This will use your operating system's playback service to provide
-        updates and controls.
+        This will use your operating system&apos;s playback service to
+        provide updates and controls.
       </p>
       <div className={styles.buttons}>
         <button onClick={onStepComplete}>Continue</button>

src/renderer/src/pages/Setup/Steps/Playback/providers/Native/Native.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect } from 'react'
+import React from 'react'
 import styles from './None.module.css'
 
 interface NoneProps {