Skip to content

Commit a917809

Browse files
committed
Update documentation
Adds a period at the end of all sentences and text fragments. After discussions with Johannes, Juan, Andreas, and ChatGPT, we concluded that consistency is more critical than grammatical correctness. Also adds documentation for some missing properties and types.
1 parent c71b744 commit a917809

File tree

6 files changed

+785
-778
lines changed

6 files changed

+785
-778
lines changed

protobuf_definitions/aquatroll.proto

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Aquatroll
22
//
3-
// These messages are emitted by the In-Situ AquaTroll 500 probe.
3+
// These messages are emitted by the In-Situ AquaTroll series of probes.
44
syntax = "proto3";
55

66
package blueye.protocol;
@@ -21,7 +21,7 @@ enum Type {
2121
TYPE_TIME = 9;
2222
}
2323

24-
// Aqua Troll Device IDs
24+
// Aqua Troll Device IDs.
2525
enum AquaTrollDevice {
2626
AQUA_TROLL_DEVICE_UNSPECIFIED = 0;
2727
AQUA_TROLL_DEVICE_LEVEL_TROLL_500 = 1;
@@ -45,7 +45,7 @@ enum AquaTrollDevice {
4545
AQUA_TROLL_DEVICE_AQUA_TROLL_500_VENTED = 34;
4646
}
4747

48-
// Aqua Troll Quality IDs
48+
// Aqua Troll Quality IDs.
4949
enum AquaTrollQuality {
5050
AQUA_TROLL_QUALITY_NORMAL = 0; // protolint:disable:this ENUM_FIELD_NAMES_ZERO_VALUE_END_WITH
5151
AQUA_TROLL_QUALITY_USER_CAL_EXPIRED = 1;
@@ -57,7 +57,7 @@ enum AquaTrollQuality {
5757
AQUA_TROLL_QUALITY_OFF_LINE = 7;
5858
}
5959

60-
// Aqua Troll Parameter IDs
60+
// Aqua Troll Parameter IDs.
6161
enum AquaTrollParameter {
6262
AQUA_TROLL_PARAMETER_UNSPECIFIED = 0;
6363
AQUA_TROLL_PARAMETER_TEMPERATURE = 1;
@@ -119,7 +119,7 @@ enum AquaTrollParameter {
119119
AQUA_TROLL_PARAMETER_COLORED_DISSOLVED_ORGANIC_MATTER_CONCENTRATION = 87;
120120
}
121121

122-
// Aqua Troll Unit IDs
122+
// Aqua Troll Unit IDs.
123123
enum AquaTrollUnit {
124124
AQUA_TROLL_UNIT_UNSPECIFIED = 0;
125125
AQUA_TROLL_UNIT_TEMP_CELSIUS = 1;
@@ -207,7 +207,7 @@ enum AquaTrollUnit {
207207
AQUA_TROLL_UNIT_METERS_PER_SECOND = 306;
208208
}
209209

210-
// Aqua Troll Sensor IDs
210+
// Aqua Troll Sensor IDs.
211211
enum AquaTrollSensor {
212212
AQUA_TROLL_SENSOR_UNSPECIFIED = 0;
213213
AQUA_TROLL_SENSOR_TEMPERATURE = 1;
@@ -299,9 +299,9 @@ enum AquaTrollDeviceStatus {
299299
AQUA_TROLL_DEVICE_STATUS_LOW_MEMORY = 14;
300300
}
301301

302-
// In-Situ Parameter Block
302+
// In-Situ Parameter Block.
303303
//
304-
// Up to NUMBER_OF_SENSOR_PARAMETERS blocks may be part of a sensor
304+
// Up to NUMBER_OF_SENSOR_PARAMETERS blocks may be part of a sensor.
305305
message AquaTrollParameterBlock {
306306
reserved 4;
307307
reserved "data_quality_id";
@@ -314,12 +314,12 @@ message AquaTrollParameterBlock {
314314
repeated AquaTrollUnit available_units = 6;
315315
}
316316

317-
// In-Situ AquaTroll 500 sensor metadata
317+
// In-Situ AquaTroll 500 sensor metadata.
318318
//
319319
// (Mostly) static information about a connected sensor.
320320
//
321321
// Refer to Section 7 Sensor Common Registers in the In-Situ Modbus
322-
// Communication Protocol
322+
// Communication Protocol.
323323
message AquaTrollSensorMetadata {
324324
reserved 4;
325325
reserved "sensor_status";
@@ -392,14 +392,14 @@ message AquaTrollSensorParametersArray {
392392
repeated AquaTrollSensorParameters sensors = 2;
393393
}
394394

395-
// Request to set an In-Situ Aqua Troll parameter unit
395+
// Request to set an In-Situ Aqua Troll parameter unit.
396396
message SetAquaTrollParameterUnit {
397-
AquaTrollSensor sensor_id = 1; // Sensor id, f. ex. "SENSOR_CONDUCTIVITY_SENSOR"
398-
AquaTrollParameter parameter_id = 2; // Parameter name, f. ex. "PARAMETER_TEMPERATURE"
399-
AquaTrollUnit unit_id = 3; // Unit, f. ex. "UNIT_TEMP_CELSIUS"
397+
AquaTrollSensor sensor_id = 1; // Sensor id, f. ex. "SENSOR_CONDUCTIVITY_SENSOR".
398+
AquaTrollParameter parameter_id = 2; // Parameter name, f. ex. "PARAMETER_TEMPERATURE".
399+
AquaTrollUnit unit_id = 3; // Unit, f. ex. "UNIT_TEMP_CELSIUS".
400400
}
401401

402-
// Request to change the In-Situ Aqua Troll connection status
402+
// Request to change the In-Situ Aqua Troll connection status.
403403
message SetAquaTrollConnectionStatus {
404-
bool connected = 1; // True to connect, false to disconnect
404+
bool connected = 1; // True to connect, false to disconnect.
405405
}

protobuf_definitions/control.proto

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -70,37 +70,37 @@ message FinishCalibrationCtrl {
7070

7171
// Issue a command to set auto heading to a desired state.
7272
message AutoHeadingCtrl {
73-
AutoHeadingState state = 1; // State of the heading controller
73+
AutoHeadingState state = 1; // State of the heading controller.
7474
}
7575

7676
// Issue a command to set auto depth to a desired state.
7777
message AutoDepthCtrl {
78-
AutoDepthState state = 1; // State of the depth controller
78+
AutoDepthState state = 1; // State of the depth controller.
7979
}
8080

8181
// Issue a command to set auto altitude to a desired state.
8282
message AutoAltitudeCtrl {
83-
AutoAltitudeState state = 1; // State of the altitude controller
83+
AutoAltitudeState state = 1; // State of the altitude controller.
8484
}
8585

8686
// Issue a command to set station keeping to a desired state.
8787
message StationKeepingCtrl {
88-
StationKeepingState state = 1; // State of the station keeping controller
88+
StationKeepingState state = 1; // State of the station keeping controller.
8989
}
9090

9191
// Issue a command to set station keeping with weather vaning to a desired state.
9292
message WeatherVaningCtrl {
93-
WeatherVaningState state = 1; // State of the weather vaning controller
93+
WeatherVaningState state = 1; // State of the weather vaning controller.
9494
}
9595

9696
// Issue a command to set Auto Pilot for cruising and turning to a desired state.
9797
message AutoPilotSurgeYawCtrl {
98-
AutoPilotSurgeYawState state = 1; // State of the auto pilot surge yaw controller
98+
AutoPilotSurgeYawState state = 1; // State of the auto pilot surge yaw controller.
9999
}
100100

101101
// Issue a command to set Auto Pilot for vertiacl movement to a desired state.
102102
message AutoPilotHeaveCtrl {
103-
AutoPilotHeaveState state = 1; // State of the auto pilot heave controller
103+
AutoPilotHeaveState state = 1; // State of the auto pilot heave controller-
104104
}
105105

106106
// Issue a command to start and pause the loaded mission.
@@ -163,42 +163,42 @@ message MultibeamServoCtrl {
163163
MultibeamServo servo = 1; // Message with the desired servo angle.
164164
}
165165

166-
// Deactivate the guest port power
166+
// Deactivate the guest port power.
167167
message DeactivateGuestPortsCtrl {
168168
}
169169

170-
// Activated the guest port power
170+
// Activated the guest port power.
171171
message ActivateGuestPortsCtrl {
172172
}
173173

174-
// Restart the guest ports by turning power on and off
174+
// Restart the guest ports by turning power on and off.
175175
message RestartGuestPortsCtrl {
176176
GuestPortRestartInfo restart_info = 1; // Message with information about how long to keep the guest ports off.
177177
}
178178

179-
// Request to set an In-Situ Aqua Troll parameter unit
179+
// Request to set an In-Situ Aqua Troll parameter unit.
180180
message SetAquaTrollParameterUnitCtrl {
181181
// Message with information about which parameter to set and the unit to set it to.
182182
SetAquaTrollParameterUnit parameter_info = 1;
183183
}
184184

185-
// Request to change the In-Situ Aqua Troll connection status
185+
// Request to change the In-Situ Aqua Troll connection status.
186186
message SetAquaTrollConnectionStatusCtrl {
187187
// Message with information about which parameter to set and the unit to set it to.
188188
SetAquaTrollConnectionStatus connection_status = 1;
189189
}
190190

191-
// Update multibeam settings
191+
// Update the multibeam settings.
192192
message SetMultibeamConfigCtrl {
193193
MultibeamConfig config = 1; // Message with the multibeam ping configuration to set.
194194
}
195195

196-
// Activate multibeam
196+
// Activate the multibeam with specified configuration.
197197
message ActivateMultibeamCtrl {
198-
MultibeamConfig config = 1; // Message with the multibeam ping configuration to set on connect
198+
MultibeamConfig config = 1; // Message with the multibeam ping configuration to set on connect.
199199
}
200200

201-
// Deactivate multibeam
201+
// Deactivate the multibeam.
202202
message DeactivateMultibeamCtrl {
203203
}
204204

0 commit comments

Comments
 (0)