Integrating Anil's review including large extension of the create_acc testsuite and refactoring ACC/JSON exporter, rename output_acc to write_acc and make it a method of cell models

Author: lukasgd

README.rst

@@ -107,6 +107,7 @@ We are providing support using a chat channel on `Gitter <https://gitter.im/Blue
 
 News
 ====
+- 2022/10/31: BluePyOpt now supports Arbor simulator.
 - 2021/08/30: BluePyOpt dropped Python 2.7 support.
 - 2017/01/04: BluePyOpt is now considered compatible with Python 3.6+.
 - 2016/11/10: BluePyOpt now supports NEURON point processes. This means we can fit parameters of Adex/GIF/Izhikevich models, and also synapse models.

bluepyopt/ephys/acc_utils.py bluepyopt/ephys/acc.pybluepyopt/ephys/acc_utils.py renamed to bluepyopt/ephys/acc.py

@@ -1,3 +1,5 @@
+'''Dependencies of Arbor simulator backend'''
+
 try:
     import arbor
 except ImportError as e:
@@ -13,15 +15,17 @@ def __getattribute__(self, _):
 class ArbLabel:
     """Arbor label"""
 
-    def __init__(self, type, name, defn):
+    def __init__(self, type, name, s_expr):
+        if type not in ['locset', 'region', 'iexpr']:
+            raise ValueError('Invalid Arbor label type %s' % type)
         self._type = type
         self._name = name
-        self._defn = defn
+        self._s_expr = s_expr
 
     @property
     def defn(self):
         """Label definition for label-dict"""
-        return '(%s-def "%s" %s)' % (self._type, self._name, self._defn)
+        return '(%s-def "%s" %s)' % (self._type, self._name, self._s_expr)
 
     @property
     def ref(self):
@@ -35,11 +39,19 @@ def name(self):
 
     @property
     def loc(self):
-        """Expression defining the location of the label"""
-        return self._defn
+        """S-expression defining the location of the label"""
+        return self._s_expr
 
     def __eq__(self, other):
-        return self.defn == other.defn
+        if other is None:
+            return False
+        elif not isinstance(other, ArbLabel):
+            raise TypeError('%s is not an ArbLabel' % str(other))
+        else:
+            return self._s_expr == other._s_expr
 
     def __hash__(self):
-        return hash(self.defn)
+        return hash(self._s_expr)
+
+    def __repr__(self):
+        return self.defn