Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Commit 1a3bfa3

Browse files
authored
Bug fix for PR #385 : add missing const for virtual method (#394)
* Bug fix for PR #385 : add missing `const` for virtual method - changing base class method prototype result into bug for virtual method in PlayRecordEvent * Additional improvements with override for virtual functions
1 parent bd747a8 commit 1a3bfa3

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

coreneuron/utils/vrecitem.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ class PlayRecordEvent : public DiscreteEvent {
4242
public:
4343
PlayRecordEvent();
4444
virtual ~PlayRecordEvent();
45-
virtual void deliver(double, NetCvode*, NrnThread*);
46-
virtual void pr(const char*, double t, NetCvode*);
45+
virtual void deliver(double, NetCvode*, NrnThread*) override;
46+
virtual void pr(const char*, double t, NetCvode*) override;
4747
virtual NrnThread* thread();
4848
PlayRecord* plr_;
4949
static unsigned long playrecord_send_;
5050
static unsigned long playrecord_deliver_;
51-
virtual int type() {
51+
virtual int type() const override {
5252
return PlayRecordEventType;
5353
}
5454
};
@@ -68,7 +68,7 @@ class PlayRecord {
6868
return nullptr;
6969
}
7070
virtual void pr(); // print identifying info
71-
virtual int type() {
71+
virtual int type() const {
7272
return 0;
7373
}
7474

@@ -80,21 +80,21 @@ class VecPlayContinuous : public PlayRecord {
8080
public:
8181
VecPlayContinuous(double*, IvocVect&& yvec, IvocVect&& tvec, IvocVect* discon, int ith);
8282
virtual ~VecPlayContinuous();
83-
virtual void play_init();
84-
virtual void deliver(double tt, NetCvode*);
85-
virtual PlayRecordEvent* event() {
83+
virtual void play_init() override;
84+
virtual void deliver(double tt, NetCvode*) override;
85+
virtual PlayRecordEvent* event() override {
8686
return e_;
8787
}
88-
virtual void pr();
88+
virtual void pr() override;
8989

90-
void continuous(double tt);
90+
void continuous(double tt) override;
9191
double interpolate(double tt);
9292
double interp(double th, double x0, double x1) {
9393
return x0 + (x1 - x0) * th;
9494
}
9595
void search(double tt);
9696

97-
virtual int type() {
97+
virtual int type() const override {
9898
return VecPlayContinuousType;
9999
}
100100

0 commit comments

Comments
 (0)